Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openshift_auth molecule tests only work when run from a pod in the cluster #35

Closed
fabianvf opened this issue Sep 21, 2020 · 2 comments · Fixed by #90
Closed

openshift_auth molecule tests only work when run from a pod in the cluster #35

fabianvf opened this issue Sep 21, 2020 · 2 comments · Fixed by #90
Assignees
Labels
has_pr This issue has a related PR that may close it. priority/low type/bug Something isn't working

Comments

@fabianvf
Copy link
Member

SUMMARY

The molecule tests for openshift_auth have the host hardcoded to https://kubernetes.default.svc, which is the fqdn for the API server when running as a pod in the cluster. We should make the task able to determine whether it's running incluster or not, and have it determine the proper host. Ideally, this can be done via the planned community.kubernetes.k8s_cluster_info module

ISSUE TYPE
  • Bug Report
COMPONENT NAME

tests

ANSIBLE VERSION

CONFIGURATION

OS / ENVIRONMENT
STEPS TO REPRODUCE
EXPECTED RESULTS
ACTUAL RESULTS

@tima tima added priority/low type/bug Something isn't working labels Sep 28, 2020
@alinabuzachis
Copy link
Contributor

Hello @fabianvf, do you know if there is a way to solve this issue? If not, can we close this?

@fabianvf
Copy link
Member Author

@alinabuzachis this should now be possible using the connection.host value returned by the k8s_cluster_info module https://github.com/ansible-collections/community.kubernetes/blob/main/plugins/modules/k8s_cluster_info.py#L64

@abikouo abikouo added the has_pr This issue has a related PR that may close it. label May 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
has_pr This issue has a related PR that may close it. priority/low type/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants