Skip to content

Latest commit

 

History

History
91 lines (72 loc) · 3.11 KB

CONTRIBUTING.md

File metadata and controls

91 lines (72 loc) · 3.11 KB
Raw

How to report issues

Before reporting an issue with GitHub, be sure that:

  • You are using the latest released version of Rizin or the latest git version
  • You are using a clean installation
  • The issue was not already reported

When the above conditions are satisfied, feel free to submit an issue while trying to be as precise as possible. If you can, provide the problematic binary, the steps to reproduce the error and a backtrace in case of SEGFAULTs. Try to follow the issue template that comes by default. Any information will help to fix the problem.

How to contribute

There are a few guidelines that we need contributors to follow so that we can try to keep the codebase consistent and clean.

Getting Started

  • Make sure you have a GitHub account and solid ability to use git.
  • Fork the repository on GitHub.
  • Create a topic branch from dev. Please avoid working directly on the dev branch.
  • Make commits of logical units.
  • Be sure to follow the CODINGSTYLE (more on this in DEVELOPERS.md).
  • Submit the Pull Request(PR) on Github.
  • When relevant, write a test in test/.

Rebasing onto updated dev

Every so often, your PR will lag behind dev and get conflicts.

To "update" your branch my-awesome-feature, you rebase it onto the latest rizinorg/dev, and force-push the result into your fork.

Step 1: Switch to dev branch.

$ git checkout dev

Step 2: Pull new commits published to rizinorg repo.

$ git pull https://github.com/rizinorg/rizin

Step 3: Switch back to my-awesome-feature branch.

$ git checkout my-awesome-feature

Step 4: Rebase the my-awesome-feature branch.

$ git rebase dev

Optionally, use the alternative mode "interactive rebase". It allows to squash your commits all into one, reorder, reword them, etc.

$ git rebase -i dev

Follow git instructions when conflicts arise.

Step 5: Publish your updated local branch.

$ git push -f

This -f force-flag is needed because git commits are immutable: rebasing creates newer versions of them. git needs to confirm the destruction of previous incarnations.

When afraid to touch force and risk losing your work (do backups!..), try merging dev into your branch instead of rebasing onto it. This is discouraged, as it produces ugly hard-to-maintain commit history.

Commit message rules

When committing your changes into the repository you may want to follow some rules to make the git history more readable and consistent:

  • Start the message capitalized (only the first character must be in uppercase)
  • Be short and concise, the whole concept must fit one line
  • If a command is inlined, use backticks
  • For extra details, add an empty line and use asterisk item list below
  • Use present simple grammar tense (Add vs Added, Fix vs Fixed/Fixes)

Additional resources

If you need more confidence in your git skills, check out this quick guide: https://learnxinyminutes.com/docs/git/