Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Default labeling rule for security based tenancy labeling #4402

Open
Tracked by #11522 ...
ansjcy opened this issue Jun 5, 2024 · 1 comment
Open
Tracked by #11522 ...

[FEATURE] Default labeling rule for security based tenancy labeling #4402

ansjcy opened this issue Jun 5, 2024 · 1 comment
Labels
enhancement New feature or request triaged Issues labeled as 'Triaged' have been reviewed and are deemed actionable.

Comments

@ansjcy
Copy link
Member

ansjcy commented Jun 5, 2024

Is your feature request related to a problem?
As part of the effort to introduce multi-tenancy as a construct in OpenSearch (opensearch-project/OpenSearch#13341), we are introducing a labeling service to attach tenancy labels to search requests. Plugins can define their rules to compute labels based on the given request and thread context. We need to add a "default" labeling rule in security plugin to get the tenancy information if the cluster is using security plugin as their auth method as part of opensearch-project/OpenSearch#13374

What solution would you like?
Add a default labeling rule so that we can attach user info in a request.

What alternatives have you considered?
We can also maintain all rules in the core repo, but it would be better to let plugins implement their own rules, which would get registered with the RuleBasedLabelingService in core.

Do you have any additional context?
Please see
opensearch-project/OpenSearch#13341
opensearch-project/OpenSearch#13374

@ansjcy ansjcy added enhancement New feature or request untriaged Require the attention of the repository maintainers and may need to be prioritized labels Jun 5, 2024
@stephen-crawford
Copy link
Contributor

stephen-crawford commented Jun 10, 2024

[Triage] Hi @ansjcy, thanks for filing this issue. From speaking with @cwperks, this work is currently paused based on some core work you are doing. That being said, feel free to resume work on the PR when you are ready to move forward.

@stephen-crawford stephen-crawford added triaged Issues labeled as 'Triaged' have been reviewed and are deemed actionable. and removed untriaged Require the attention of the repository maintainers and may need to be prioritized labels Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request triaged Issues labeled as 'Triaged' have been reviewed and are deemed actionable.
Projects
None yet
Development

No branches or pull requests

2 participants