Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Extensions] Modify Job Schedule's ScheduleParser to read in the refresh token field #2627

Closed
Tracked by #2528
cwperks opened this issue Mar 31, 2023 · 2 comments
Closed
Tracked by #2528
Labels
triaged Issues labeled as 'Triaged' have been reviewed and are deemed actionable.

Comments

@cwperks
Copy link
Member

cwperks commented Mar 31, 2023

The ScheduleParser class in Job Scheduler is responsible for reading from schedules from within job definition's registered to the Job Scheduler. Plugin's make Job Scheduler aware of indices they will use to store job definitions and part of those job definitions contains information about the schedule.

The schedule information will also now include a refresh_token which identifies the creator (owner) of the job definition. The ScheduleParser needs to be updated to read this additional field.

@github-actions github-actions bot added the untriaged Require the attention of the repository maintainers and may need to be prioritized label Mar 31, 2023
@stephen-crawford stephen-crawford added triaged Issues labeled as 'Triaged' have been reviewed and are deemed actionable. and removed untriaged Require the attention of the repository maintainers and may need to be prioritized labels Apr 3, 2023
@stephen-crawford
Copy link
Contributor

[Triage] This is part of the Extensions project.

@cwperks
Copy link
Member Author

cwperks commented May 16, 2023

Closing this issue. The user information will not be stored in indices owned by plugins/extensions as an extension is free to override values at any moment. The user info associated with job details should be stored in a secure index where it can be properly protected.

@cwperks cwperks closed this as completed May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triaged Issues labeled as 'Triaged' have been reviewed and are deemed actionable.
Projects
Status: Done
Development

No branches or pull requests

2 participants