diff --git a/.github/workflows/unit-tests-workflow.yml b/.github/workflows/unit-tests-workflow.yml index ce58c0f3a..6533c46c7 100644 --- a/.github/workflows/unit-tests-workflow.yml +++ b/.github/workflows/unit-tests-workflow.yml @@ -7,7 +7,7 @@ on: branches: - "*" env: - OPENSEARCH_DASHBOARDS_VERSION: '2.x' + OPENSEARCH_DASHBOARDS_VERSION: '2.15.0' jobs: Get-CI-Image-Tag: uses: opensearch-project/opensearch-build/.github/workflows/get-ci-image-tag.yml@main diff --git a/public/pages/CreateDetector/components/DefineDetector/components/DetectorSchedule/DetectorSchedule.tsx b/public/pages/CreateDetector/components/DefineDetector/components/DetectorSchedule/DetectorSchedule.tsx index 0bafe87ef..c55a6417a 100644 --- a/public/pages/CreateDetector/components/DefineDetector/components/DetectorSchedule/DetectorSchedule.tsx +++ b/public/pages/CreateDetector/components/DefineDetector/components/DetectorSchedule/DetectorSchedule.tsx @@ -4,7 +4,7 @@ */ import React from 'react'; -import { EuiSpacer, EuiTitle } from '@elastic/eui'; +import { EuiSpacer, EuiText } from '@elastic/eui'; import { PeriodSchedule } from '../../../../../../../models/interfaces'; import { Interval } from './Interval'; import { Detector } from '../../../../../../../types'; @@ -23,9 +23,9 @@ export class DetectorSchedule extends React.Component { render() { return ( <> - +

Detector schedule

-
+ void; } @@ -14,25 +23,67 @@ export interface ThreatIntelligenceProps { export const ThreatIntelligence: React.FC = ({ threatIntelChecked, onThreatIntelChange, + isEdit, }) => { + const [shouldShowEditUI] = useState(isEdit && threatIntelChecked); + const threatIntelUrl = useMemo(() => { + return `#${ROUTES.THREAT_INTEL_OVERVIEW}`; + }, []); + return ( <> - -

Threat intelligence feeds

-
+ {!shouldShowEditUI && ( + <> + +

Threat intelligence feeds

+
+ +

+ To match your data source against known indicators of compromise configure logs scan + with threat intel sources on the{' '} + + Threat intelligence + {' '} + page. +

+
+ + )} + {shouldShowEditUI && ( + <> + +

Threat intelligence feeds

+
- -

- Match your data source against known malicious IP-addresses. Available for standard log - types only. -

-
- onThreatIntelChange(e.target.checked)} - /> + +

+ Match your data source against known malicious IP-addresses. Available for standard + log types only. +

+
+ + + To match your data against known indicators of compromise we recommend configuring + scan using the new{' '} + + Threat Intelligence + {' '} + platform and disabling threat intelligence in the detector. +

+ } + /> + + onThreatIntelChange(e.target.checked)} + /> + + )} ); }; diff --git a/public/pages/CreateDetector/components/DefineDetector/containers/DefineDetector.tsx b/public/pages/CreateDetector/components/DefineDetector/containers/DefineDetector.tsx index bad210417..a356673cc 100644 --- a/public/pages/CreateDetector/components/DefineDetector/containers/DefineDetector.tsx +++ b/public/pages/CreateDetector/components/DefineDetector/containers/DefineDetector.tsx @@ -146,7 +146,7 @@ export default class DefineDetector extends Component diff --git a/public/pages/Detectors/components/DetectorBasicDetailsView/DetectorBasicDetailsView.tsx b/public/pages/Detectors/components/DetectorBasicDetailsView/DetectorBasicDetailsView.tsx index 56bd96e53..912fd15a9 100644 --- a/public/pages/Detectors/components/DetectorBasicDetailsView/DetectorBasicDetailsView.tsx +++ b/public/pages/Detectors/components/DetectorBasicDetailsView/DetectorBasicDetailsView.tsx @@ -3,12 +3,12 @@ * SPDX-License-Identifier: Apache-2.0 */ -import { EuiButton, EuiSpacer, EuiLink, EuiIcon, EuiText } from '@elastic/eui'; +import { EuiButton, EuiSpacer, EuiLink, EuiIcon, EuiText, EuiCallOut } from '@elastic/eui'; import React from 'react'; import { ContentPanel } from '../../../../components/ContentPanel'; import { createTextDetailsGroup, parseSchedule } from '../../../../utils/helpers'; import moment from 'moment'; -import { DEFAULT_EMPTY_DATA, logTypesWithDashboards } from '../../../../utils/constants'; +import { DEFAULT_EMPTY_DATA, logTypesWithDashboards, ROUTES } from '../../../../utils/constants'; import { Detector } from '../../../../../types'; import { getLogTypeLabel } from '../../../LogTypes/utils/helpers'; @@ -101,6 +101,21 @@ export const DetectorBasicDetailsView: React.FC = {createTextDetailsGroup([ { label: 'Threat intelligence', content: threat_intel_enabled ? 'Enabled' : 'Disabled' }, ])} + {threat_intel_enabled && ( + + To match your data against known indicators of compromise we recommend configuring + scan using the new{' '} + + Threat Intelligence + {' '} + platform and disabling threat intelligence in the detector. +

+ } + /> + )} {rulesCanFold ? children : null} ); diff --git a/public/pages/Detectors/components/UpdateBasicDetails/UpdateBasicDetails.tsx b/public/pages/Detectors/components/UpdateBasicDetails/UpdateBasicDetails.tsx index 3ba0c4aa1..279d9cb01 100644 --- a/public/pages/Detectors/components/UpdateBasicDetails/UpdateBasicDetails.tsx +++ b/public/pages/Detectors/components/UpdateBasicDetails/UpdateBasicDetails.tsx @@ -292,6 +292,7 @@ export const UpdateDetectorBasicDetails: React.FC diff --git a/public/pages/Detectors/components/UpdateBasicDetails/__snapshots__/UpdateDetectorBasicDetails.test.tsx.snap b/public/pages/Detectors/components/UpdateBasicDetails/__snapshots__/UpdateDetectorBasicDetails.test.tsx.snap index cc9ea1d72..1587b0dc2 100644 --- a/public/pages/Detectors/components/UpdateBasicDetails/__snapshots__/UpdateDetectorBasicDetails.test.tsx.snap +++ b/public/pages/Detectors/components/UpdateBasicDetails/__snapshots__/UpdateDetectorBasicDetails.test.tsx.snap @@ -1144,57 +1144,67 @@ exports[` spec renders the component 1`] = ` />
- -

- Threat intelligence feeds -

-
-
-

- Match your data source against known malicious IP-addresses. Available for standard log types only. -

+

+ Threat intelligence feeds +

-
- -
- +

+ To match your data source against known indicators of compromise configure logs scan with threat intel sources on the + + + + Threat intelligence + + EuiIconMock + + + + + (opens in a new tab or window) + + + + + + + page. +

- + spec renders the component 1`] = ` } onDetectorScheduleChange={[Function]} > - -

- Detector schedule -

-
+

+ Detector schedule +

+
+