Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cluster:admin/opendistro/reports/definition/delete wasn't rebranded #187

Closed
JeffAshton opened this issue Oct 22, 2021 · 2 comments
Closed

cluster:admin/opendistro/reports/definition/delete wasn't rebranded #187

JeffAshton opened this issue Oct 22, 2021 · 2 comments
Assignees
@davidcui1225
Labels
bug Something isn't working

Comments

@JeffAshton
Copy link

JeffAshton commented Oct 22, 2021 •
edited
Loading

Is your feature request related to a problem? Please describe.

cluster:admin/opendistro/reports/definition/delete was missed during the OpenSearch rebranding. Leaving it an outcast from the other permissions:

https://github.com/opensearch-project/dashboards-reports/blob/b62ba6e551a82624db44a1cb06028ff269d19ec7/reports-scheduler/src/main/kotlin/org/opensearch/reportsscheduler/action/DeleteReportDefinitionAction.kt#L54

image

Describe the solution you'd like

Align it with all the other cluster:admin/opensearch/reports/* permissions.
@JeffAshton JeffAshton added the enhancement New feature or request label Oct 22, 2021
@zhongnansu zhongnansu mentioned this issue Nov 3, 2021
Closed
6 tasks
@anirudha
Copy link
Collaborator

anirudha commented Nov 9, 2021

closed as a dupe

@anirudha anirudha closed this as completed Nov 9, 2021
@zhongnansu
Copy link
Member

Refer to the discussion in #223

@zhongnansu zhongnansu added bug Something isn't working and removed enhancement New feature or request labels Nov 9, 2021
@zhongnansu zhongnansu mentioned this issue Dec 14, 2021
Merged
6 tasks
@camAtGitHub camAtGitHub mentioned this issue Jan 4, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davidcui1225 davidcui1225

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@anirudha @JeffAshton @zhongnansu @davidcui1225