Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary map of QueryBuilders to fieldName function #109

Closed
jainankitk opened this issue Sep 9, 2024 · 0 comments · Fixed by #111
Closed

Remove unnecessary map of QueryBuilders to fieldName function #109

jainankitk opened this issue Sep 9, 2024 · 0 comments · Fixed by #111
Assignees
@dzane17
Labels
bug Something isn't working untriaged

Comments

@jainankitk
Copy link
Collaborator

With the introduction of WithFieldName interface in core Opensearch, QueryBuilder can directly be checked as instanceof WithFieldName instead of maintaining the map of QueryBuilders to fieldName function.
@jainankitk jainankitk added bug Something isn't working untriaged and removed untriaged labels Sep 9, 2024
@jainankitk jainankitk self-assigned this Sep 9, 2024
@jainankitk jainankitk assigned dzane17 and unassigned jainankitk Sep 9, 2024
@dzane17 dzane17 mentioned this issue Sep 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dzane17 dzane17

Labels
bug Something isn't working untriaged
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor query shape field data maps dzane17/query-insights
2 participants
@jainankitk @dzane17