Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.1 .Net client release with OpenSearch 2.0 support #76

Closed
15 tasks done
Yury-Fridlyand opened this issue Aug 9, 2022 · 6 comments
Closed
15 tasks done

1.1 .Net client release with OpenSearch 2.0 support #76

Yury-Fridlyand opened this issue Aug 9, 2022 · 6 comments

Comments

@Yury-Fridlyand
Copy link
Collaborator

Yury-Fridlyand commented Aug 9, 2022

Acceptance criteria

  • All CI pass
  • OpenSearch 2.0 is fully supported
  • OpenSearch 1.x is fully supported
  • No breaking changes
  • Nuget packages are available for download and use

PR to complete

Release Process

https://github.com/opensearch-project/opensearch-net/blob/main/RELEASING.md

  • Release branch created for 1.1 release
  • Release branch created for the next 1.x release

See also

@thespatt
Copy link

thespatt commented Aug 16, 2022

Being that 1.0.0 of the .net client does not work with OpenSearch 2.2:
image
Is there a reason 2.0 isn't more appropriate than 1.1? I think it would eliminate some confusion.

@Yury-Fridlyand
Copy link
Collaborator Author

It is supposed that next release of the client would have version 1.1. Anyway it will support OpenSearch 2.0. Please, see compatibility matrix in PR #51.
The client version is TBD actually, it could be released as 2.0.

@wbeckler
Copy link

wbeckler commented Aug 17, 2022

@thespatt The logic is that, under semver principles, saying "2.0" means that this client breaks compatibility with code that works with the 1.0 client. Instead, the upcoming version only adds features. So under semver it would be a minor version increment.

The day might come when a version of the client actually does become incompatible with current working application code. In that case we'd increment the major version as a signal that application builders need to do a heavier duty upgrade rather than just a version increment.

On the other hand, we don't want to generate serious confusion, so please update here if this logic doesn't make sense.

@harshavamsi
Copy link
Contributor

@Yury-Fridlyand @MaxKsyunz can you create a 1.1 branch with all commits for release?

@Yury-Fridlyand
Copy link
Collaborator Author

@harshavamsi,
Done: 1.1.0

@Yury-Fridlyand Yury-Fridlyand unpinned this issue Sep 15, 2022
@Yury-Fridlyand
Copy link
Collaborator Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants