Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Guide] Search #473

Closed
Tracked by #475
nhtruong opened this issue Apr 4, 2023 · 6 comments · Fixed by #488 or #489
Closed
Tracked by #475

[Guide] Search #473

nhtruong opened this issue Apr 4, 2023 · 6 comments · Fixed by #488 or #489
Assignees
Labels
CCI College Contributor Initiative good first issue Good for newcomers

Comments

@nhtruong
Copy link
Collaborator

nhtruong commented Apr 4, 2023

Create guides/search.md similar to the Ruby guide

You must assure that:

  • All code-blocks, when run from start to finish in order they appear in the guide, do not throw any errors. If you want to demonstrate that certain statements will throw errors, they must be wrapped in a try/catch and print out the expected error.
  • All code-blocks are properly marked with the language it's written in (i.e. ```ruby)
  • The instructions, though mostly identical to the Ruby guide, are suitable for this repo.
@nhtruong nhtruong added good first issue Good for newcomers untriaged CCI College Contributor Initiative labels Apr 4, 2023
@nhtruong nhtruong mentioned this issue Apr 4, 2023
6 tasks
@nhtruong nhtruong removed the untriaged label Apr 4, 2023
@sayuree
Copy link
Contributor

sayuree commented Apr 6, 2023

Hi, I want to work on this issue

@nhtruong
Copy link
Collaborator Author

nhtruong commented Apr 6, 2023

@sayuree go for it :)

@Nicksqain
Copy link
Contributor

@nhtruong I already had a guide ready, can I do a PR? It's not very right of me, but I didn't work for nothing either :[

@sayuree
Copy link
Contributor

sayuree commented Apr 11, 2023

@Nicksqain Well, I assume that according to the code of conduct, you are not allowed to work on already assigned issues. I admit that I did not submit the changes/commits right away, but still, it does not give an opportunity for others to take up the issue. There are still a bunch of issues you could work on, instead of attaching PR on already assigned ones. Please consider the code of conduct in the future.

@Nicksqain
Copy link
Contributor

@nhtruong Yes, I apologize for my actions. It won't happen again. If suddenly the appointed person for some reason will not be able to work, then please accept my candidacy. I'm not trying to take away the time spent. It's just that I already did, but couldn't ask to be assigned to me. I apologize again.

@nhtruong
Copy link
Collaborator Author

@Nicksqain It's all good. I appreciate your candor and passion for this project. Since @sayuree has already been assigned to this issue, they have the priority on this issue. Feel free to pick up any other unclaimed issues and keep up the great work :D

@sayuree sayuree mentioned this issue Apr 12, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CCI College Contributor Initiative good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants