Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Requirements] IM needs JS 1.2.0 SPI in Maven Snapshots to work #663

Closed
peterzhuamazon opened this issue Sep 30, 2021 · 3 comments · Fixed by #664
Closed

[Requirements] IM needs JS 1.2.0 SPI in Maven Snapshots to work #663

peterzhuamazon opened this issue Sep 30, 2021 · 3 comments · Fixed by #664
Assignees
Labels
enhancement New Enhancement v1.2.0 OpenSearch 1.2 version

Comments

@peterzhuamazon
Copy link
Member

Is your feature request related to a problem? Please describe

Per @dbbaughe,

We have changes going into job scheduler 1.2 and they are in the main branch, and we have a PR in index management that relies on those changes so it needs to be able to pull down the 1.2 snapshot if we bump them both to 1.2

We need to deploy 1.2 jars to maven as majority of the plugin owners are working on it in main branch of their repos.

Describe the solution you'd like

Create 1.2.0 manifest and deploy to maven snapshots.

Describe alternatives you've considered

No response

Additional context

No response

@peterzhuamazon peterzhuamazon added enhancement New Enhancement v1.2.0 OpenSearch 1.2 version labels Sep 30, 2021
@peterzhuamazon peterzhuamazon self-assigned this Sep 30, 2021
@peterzhuamazon peterzhuamazon linked a pull request Sep 30, 2021 that will close this issue
1 task
@dbbaughe
Copy link
Contributor

As mentioned by Peter, we have already cut 1.1 branches for Job Scheduler and Index Management, and now we have a new feature going into the main branches of each w/ IM depending on the code changes in Job Scheduler. If we want to rely on using the snapshots for the dependencies in CI then we need to be able to bump the Job Scheduler/Index Management/other plugins to 1.2 and have the equivalent 1.2 SNAPSHOT jars/etc. created for the ones that publish something.

Otherwise we would have to revert back to checking out and building everything locally.

@dblock
Copy link
Member

dblock commented Sep 30, 2021

  1. Make sure common-utils and job-scheduler have incremented their versions to 1.2.
  2. Add them to the 1.2 manifest.
  3. Start building 1.2 in https://github.com/opensearch-project/opensearch-build/blob/main/bundle-workflow/Jenkinsfile#L8.

@dblock
Copy link
Member

dblock commented Sep 30, 2021

@dbbaughe You should be able to PR all those changes, too!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New Enhancement v1.2.0 OpenSearch 1.2 version
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants