Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] OpenSearch-Dashboards integTest does not uninstall OpenSearch after completion #3524

Closed
peterzhuamazon opened this issue May 16, 2023 · 3 comments · Fixed by #3823
Closed
Assignees

Comments

@peterzhuamazon
Copy link
Member

Hi,

When running the OSD integTest through Python, both OS and OSD will be installed.
But when completing the test or failed the test, only OSD will be uninstalled.

The logic here should be finetuned, this is only for DEB/RPM, not for TAR due to how uninstall function is being written:
https://github.com/opensearch-project/opensearch-build/blob/main/src/test_workflow/integ_test/distribution_rpm.py#L56
https://github.com/opensearch-project/opensearch-build/blob/main/src/test_workflow/integ_test/distribution_deb.py#L54

Thanks.

@github-actions github-actions bot added the untriaged Issues that have not yet been triaged label May 16, 2023
@peterzhuamazon
Copy link
Member Author

def start(self) -> None:
        os.makedirs(self.work_dir, exist_ok=True)

        self.all_services = [self.service] + self.dependencies

        for service in self.all_services:
            service.start()

        for service in self.all_services:
            service.wait_for_service()

@peterzhuamazon
Copy link
Member Author

We might able to retrieve the above service list and run the uninstall based on that.
In src/test_workflow/test_cluster.py

@zelinh zelinh removed the untriaged Issues that have not yet been triaged label May 23, 2023
@zelinh
Copy link
Member

zelinh commented May 23, 2023

[Triage] We have enough information here. @Divyaasm Please help take a look here. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
3 participants