Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make code compatible to run a docker image #332

Closed
gaiksaya opened this issue Aug 26, 2021 · 10 comments
Closed

Make code compatible to run a docker image #332

gaiksaya opened this issue Aug 26, 2021 · 10 comments
Labels
documentation Improvements or additions to documentation enhancement New Enhancement triaged This issue has been reviewed by the triage team

Comments

@gaiksaya
Copy link
Member

gaiksaya commented Aug 26, 2021

We want to make sure the code used to build/test artifacts runs on a documented docker image

  • OpenSearch Linux x64/arm64 builds/test workflows - ci-runner.centos7.dockerfile
  • OpenSearch Dashboard Linux builds - ?
  • OpenSearch Windows build workflow - ?
@dblock
Copy link
Member

dblock commented Sep 12, 2021

Needed for #33

@peternied peternied changed the title Make code compatible to run on all platforms Make code compatible to run a docker image Sep 28, 2021
@peternied
Copy link
Member

[Triage] Rather than supporting all platforms lets lock into to a docker image that will be predictable.

@peternied peternied added the triaged This issue has been reviewed by the triage team label Sep 28, 2021
@cjcjameson
Copy link

@peternied we're looking for ways to help #33 and get Windows installers. does your comment mean we should find other ways to help?

@peternied
Copy link
Member

@cjcjameson Good callout, I really should have said lock into a single version of *nix, the windows platform is entirely different and deserving of support!

If you were to start here with a docker image, that establishes the basis of a build platform - https://github.com/opensearch-project/opensearch-build/tree/main/bundle-workflow/dockerfiles

If you create a [Meta] issue to support Windows platform we could collaborate on what the roadmap would look like, or I could create it.

@bbarani
Copy link
Member

bbarani commented Nov 21, 2022

@gaiksaya Can you please review and close this issue if this has been already addressed?

@gaiksaya
Copy link
Member Author

We are good for linux but for windows @peterzhuamazon can add more. I dont think we are building on docker for windows today. https://github.com/opensearch-project/opensearch-build/blob/main/jenkins/opensearch/distribution-build.jenkinsfile#L303-L307

@peterzhuamazon
Copy link
Member

We only have windows ami as windows docker must run on windows, but we can dig into that as windows integTest would be very beneficial for this.

Thanks.

@gaiksaya
Copy link
Member Author

I believe docker image is needed for build as well. Not just integ-test. Is there a plan to add that too?

@gaiksaya gaiksaya added the documentation Improvements or additions to documentation label Jun 26, 2023
@gaiksaya
Copy link
Member Author

We have added docker images for all builds/tests/release except for windows. However, the documentation needs to be added for the same.

@gaiksaya
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New Enhancement triaged This issue has been reviewed by the triage team
Projects
None yet
Development

No branches or pull requests

6 participants