-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make code compatible to run a docker image #332
Comments
Needed for #33 |
[Triage] Rather than supporting all platforms lets lock into to a docker image that will be predictable. |
@peternied we're looking for ways to help #33 and get Windows installers. does your comment mean we should find other ways to help? |
@cjcjameson Good callout, I really should have said lock into a single version of If you were to start here with a docker image, that establishes the basis of a build platform - https://github.com/opensearch-project/opensearch-build/tree/main/bundle-workflow/dockerfiles If you create a [Meta] issue to support Windows platform we could collaborate on what the roadmap would look like, or I could create it. |
@gaiksaya Can you please review and close this issue if this has been already addressed? |
We are good for linux but for windows @peterzhuamazon can add more. I dont think we are building on docker for windows today. https://github.com/opensearch-project/opensearch-build/blob/main/jenkins/opensearch/distribution-build.jenkinsfile#L303-L307 |
We only have windows ami as windows docker must run on windows, but we can dig into that as windows integTest would be very beneficial for this. Thanks. |
I believe docker image is needed for build as well. Not just integ-test. Is there a plan to add that too? |
We have added docker images for all builds/tests/release except for windows. However, the documentation needs to be added for the same. |
Added details here: https://github.com/opensearch-project/opensearch-build/wiki/Building-an-OpenSearch-and-OpenSearch-Dashboards-Distribution#building-from-source Closing this issue. |
We want to make sure the code used to build/test artifacts runs on a documented docker image
The text was updated successfully, but these errors were encountered: