@@ -328,7 +341,7 @@ export const VisaulizationFlyout = ({
// On change of selected visualization change options
useEffect(() => {
- for (var i = 0; i < savedVisualizations.length; i++) {
+ for (let i = 0; i < savedVisualizations.length; i++) {
const visualization = savedVisualizations[i];
if (visualization.id === selectValue) {
setPPLQuery(visualization.query);
diff --git a/dashboards-observability/public/components/explorer/visualizations/config_panel/config_editor/config_controls/config_thresholds.tsx b/dashboards-observability/public/components/explorer/visualizations/config_panel/config_editor/config_controls/config_thresholds.tsx
index 81906ed66..db2aaf2b2 100644
--- a/dashboards-observability/public/components/explorer/visualizations/config_panel/config_editor/config_controls/config_thresholds.tsx
+++ b/dashboards-observability/public/components/explorer/visualizations/config_panel/config_editor/config_controls/config_thresholds.tsx
@@ -67,7 +67,7 @@ export const ConfigThresholds = ({
if (thrId !== th.thid) return th;
return {
...th,
- [thrName]: event?.target?.value || '',
+ [thrName]: (thrName === 'color' ? event : event?.target?.value) || '',
};
}),
]);
@@ -139,7 +139,7 @@ export const ConfigThresholds = ({
{
await http
.get(`${CUSTOM_PANELS_API_PREFIX}/visualizations`)
.then((res) => {
- opt2 = res.visualizations.map((vizObject) => ({
+ const noAppVisualizations = res.visualizations.filter((vis) => {
+ return !!!vis.application_id;
+ });
+ opt2 = noAppVisualizations.map((vizObject) => ({
label: vizObject.name,
key: vizObject.id,
className: 'OBSERVABILITY_VISUALIZATION',
diff --git a/dashboards-observability/public/components/trace_analytics/components/dashboard/dashboard_table.tsx b/dashboards-observability/public/components/trace_analytics/components/dashboard/dashboard_table.tsx
index 43315aeec..55af82ba4 100644
--- a/dashboards-observability/public/components/trace_analytics/components/dashboard/dashboard_table.tsx
+++ b/dashboards-observability/public/components/trace_analytics/components/dashboard/dashboard_table.tsx
@@ -112,7 +112,11 @@ export function DashboardTable(props: {
})
}
>
- {item.length < 48 ? item : {_.truncate(item, { length: 48 })}
}
+ {item.length < 48 ? (
+ decodeURI(item)
+ ) : (
+ {_.truncate(decodeURI(item), { length: 48 })}
+ )}
) : (
'-'
diff --git a/dashboards-observability/server/adaptors/custom_panels/custom_panel_adaptor.ts b/dashboards-observability/server/adaptors/custom_panels/custom_panel_adaptor.ts
index 15847404a..a11bff645 100644
--- a/dashboards-observability/server/adaptors/custom_panels/custom_panel_adaptor.ts
+++ b/dashboards-observability/server/adaptors/custom_panels/custom_panel_adaptor.ts
@@ -4,11 +4,7 @@
*/
import { v4 as uuidv4 } from 'uuid';
-import {
- CustomPanelListType,
- PanelType,
- VisualizationType,
-} from '../../../common/types/custom_panels';
+import { PanelType, VisualizationType } from '../../../common/types/custom_panels';
import { ILegacyScopedClusterClient } from '../../../../../src/core/server';
import { createDemoPanel } from '../../common/helpers/custom_panels/sample_panels';
@@ -211,7 +207,7 @@ export class CustomPanelsAdaptor {
}
};
- // parses fetched saved visualization
+ // parses fetched saved visualization
parseSavedVisualizations = (visualization: any) => {
return {
id: visualization.objectId,
@@ -224,6 +220,9 @@ export class CustomPanelsAdaptor {
user_configs: visualization.savedVisualization.hasOwnProperty('user_configs')
? JSON.parse(visualization.savedVisualization.user_configs)
: {},
+ ...(visualization.savedVisualization.application_id
+ ? { application_id: visualization.savedVisualization.application_id }
+ : {}),
};
};
@@ -233,11 +232,9 @@ export class CustomPanelsAdaptor {
const response = await client.callAsCurrentUser('observability.getObject', {
objectType: 'savedVisualization',
});
- return response.observabilityObjectList
- .filter((visualization: any) => {
- return !!!visualization.savedVisualization.application_id;
- })
- .map((visualization: any) => this.parseSavedVisualizations(visualization));
+ return response.observabilityObjectList.map((visualization: any) =>
+ this.parseSavedVisualizations(visualization)
+ );
} catch (error) {
throw new Error('View Saved Visualizations Error:' + error);
}
@@ -334,13 +331,13 @@ export class CustomPanelsAdaptor {
const allPanelVisualizations = await this.getVisualizations(client, panelId);
let newDimensions;
- let visualizationsList = [];
+ let visualizationsList = [] as VisualizationType[];
if (oldVisualizationId === undefined) {
newDimensions = this.getNewVizDimensions(allPanelVisualizations);
visualizationsList = allPanelVisualizations;
} else {
allPanelVisualizations.map((visualization: VisualizationType) => {
- if (visualization.id != oldVisualizationId) {
+ if (visualization.id !== oldVisualizationId) {
visualizationsList.push(visualization);
} else {
newDimensions = {
@@ -383,7 +380,7 @@ export class CustomPanelsAdaptor {
) => {
try {
const allPanelVisualizations = await this.getVisualizations(client, panelId);
- const filteredPanelVisualizations = [];
+ const filteredPanelVisualizations = [] as VisualizationType[];
for (let i = 0; i < allPanelVisualizations.length; i++) {
for (let j = 0; j < visualizationParams.length; j++) {