Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Tool development for Search Alerts Tool #1521

Closed
minalsha opened this issue Oct 13, 2023 · 1 comment
Closed

[FEATURE] Tool development for Search Alerts Tool #1521

minalsha opened this issue Oct 13, 2023 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@minalsha
Copy link

minalsha commented Oct 13, 2023

Is your feature request related to a problem?
Agent framework (#1161 ) needs tools to extend functionality. This issue propose to add search monitor and alert tools to it.

Get alerts: read information on
1. most recently triggered alerts
2. other alerts related to that alert by time, service attributes, or infrastructure tags or severity
3. historical trends on that alert and similar alerts
4. any unusual trends in the system behavior as reflected in anomalies or spikes/troughs
5. root cause of the system behavior that generated the alert

What solution would you like?

Agent framework (#1161 ) will provide a general tool framework. We can build search monitor/alerts tools with that framework.

  1. Build against the Tool interface on the agent_framework_dev branch: https://github.com/opensearch-project/ml-commons/blob/feature/agent_framework_dev/spi/src/main/java/org/opensearch/ml/common/spi/tools/Tool.java
  2. Review example tools in the Agent Framework POC commit: 1b85cff where there are 6 tools under ml-algorithms/src/main/java/org/opensearch/ml/engine/tools/. A good example is the CatIndices tool: https://github.com/opensearch-project/ml-commons/blob/feature/agent_framework_dev/ml-algorithms/src/main/java/org/opensearch/ml/engine/tools/CatIndexTool.java which shows how to use the NodeClient (IndicesAdminClient) to fetch Cluster Health statistics.
  3. Implement a similar tool using OpenSearch search functionality for Alerts by index, time, service attributes, and infrastructure tabs

What alternatives have you considered?
N/A

Do you have any additional context?
N/A

@minalsha minalsha added enhancement New feature or request untriaged labels Oct 13, 2023
@minalsha minalsha assigned joshpalis and unassigned joshpalis Oct 13, 2023
@minalsha minalsha changed the title [FEATURE] POC for Tool development for Search Monitor Tool and Search Alerts Tool [FEATURE] POC for Tool development for Search Alerts Tool Oct 24, 2023
@minalsha minalsha changed the title [FEATURE] POC for Tool development for Search Alerts Tool [FEATURE] Tool development for Search Alerts Tool Oct 24, 2023
@ylwu-amzn ylwu-amzn moved this to In Progress in ml-commons projects Nov 3, 2023
@ohltyler
Copy link
Member

Closed via #1629

@github-project-automation github-project-automation bot moved this from In Progress to Done in ml-commons projects Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

No branches or pull requests

4 participants