Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Use version catalog for jackson and httpcore5 dependencies #992

Closed
dbwiddis opened this issue Jan 13, 2025 · 1 comment
Closed
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@dbwiddis
Copy link
Member

Is your feature request related to a problem?

We are forcing dependency resolution on imports that conflict with OpenSearch:

flow-framework/build.gradle

Lines 212 to 213 in 0284554

force("com.fasterxml.jackson.core:jackson-core:${jacksonVersion}") // Dependency Jar Hell
force("org.apache.httpcomponents.core5:httpcore5:5.3.1") // Dependency Jar Hell

What solution would you like?

Thanks to opensearch-project/OpenSearch#16284 we can now just reference the upstream version.

See for example:

What alternatives have you considered?

Keeping track of our own version, forcing it like we do, and continually bumping it when prompted.

Do you have any additional context?

Should probably do two separate PRs as the core5 one won't get backported.

@dbwiddis
Copy link
Member Author

Completed as part of #980

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant