Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Improve testing in panels (observability dashboards with saved object) #429

Open
joshuali925 opened this issue Apr 26, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@joshuali925
Copy link
Member

joshuali925 commented Apr 26, 2023

Is your feature request related to a problem?
Observability is missing tests and does not have good coverage, PRs like #419 does not have tests

When observability dashboards were added, they were duplicated files of the old panels components. The old ones have tests but new ones do not, https://github.com/opensearch-project/dashboards-observability/blob/2.7/public/components/custom_panels/panel_modules/visualization_flyout/__tests__/visualization_flyout.test.tsx

What solution would you like?
Add tests for the new observability dashboards component under https://github.com/opensearch-project/dashboards-observability/tree/2.7/public/components/custom_panels/panel_modules/

What alternatives have you considered?
A clear and concise description of any alternative solutions or features you've considered.

Do you have any additional context?
Add any other context or screenshots about the feature request here.

@joshuali925 joshuali925 added enhancement New feature or request untriaged labels Apr 26, 2023
@joshuali925 joshuali925 changed the title [FEATURE] Improve testing in observability [FEATURE] Improve testing in panels (observability dashboards with saved object) Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant