From f3eb11b06e1c0fed009058d7473ee056d8cf466e Mon Sep 17 00:00:00 2001
From: Adam Tackett <tackadam@amazon.com>
Date: Fri, 25 Oct 2024 11:26:27 -0700
Subject: [PATCH] address comments

Signed-off-by: Adam Tackett <tackadam@amazon.com>
---
 .../components/common/filters/filters.tsx        | 16 ++++++++++------
 .../components/services/services_content.tsx     |  1 -
 .../components/traces/traces_content.tsx         |  1 -
 public/components/trace_analytics/home.tsx       |  2 +-
 4 files changed, 11 insertions(+), 9 deletions(-)

diff --git a/public/components/trace_analytics/components/common/filters/filters.tsx b/public/components/trace_analytics/components/common/filters/filters.tsx
index 9f57b9d0a..3acf5870b 100644
--- a/public/components/trace_analytics/components/common/filters/filters.tsx
+++ b/public/components/trace_analytics/components/common/filters/filters.tsx
@@ -13,6 +13,7 @@ import {
   EuiIcon,
   EuiPopover,
   EuiPopoverTitle,
+  EuiSpacer,
   EuiTextColor,
 } from '@elastic/eui';
 import React, { useMemo, useState } from 'react';
@@ -225,12 +226,15 @@ export function Filters(props: FiltersOwnProps) {
   const filterComponents = useMemo(() => renderFilters(), [props.filters]);
 
   return props.filters.length > 0 ? (
-    <EuiFlexGroup gutterSize="s" alignItems="center" responsive={false}>
-      {filterComponents}
-      <EuiFlexItem grow={false}>
-        <AddFilterButton />
-      </EuiFlexItem>
-    </EuiFlexGroup>
+    <>
+      <EuiSpacer size="s" />
+      <EuiFlexGroup gutterSize="s" alignItems="center" responsive={false}>
+        {filterComponents}
+        <EuiFlexItem grow={false}>
+          <AddFilterButton />
+        </EuiFlexItem>
+      </EuiFlexGroup>
+    </>
   ) : null;
 }
 
diff --git a/public/components/trace_analytics/components/services/services_content.tsx b/public/components/trace_analytics/components/services/services_content.tsx
index 2779751ac..d1bf6edf0 100644
--- a/public/components/trace_analytics/components/services/services_content.tsx
+++ b/public/components/trace_analytics/components/services/services_content.tsx
@@ -205,7 +205,6 @@ export function ServicesContent(props: ServicesProps) {
               />
             </EuiFlexItem>
           </EuiFlexGroup>
-          {props.filters.length > 0 && <EuiSpacer size="s" />}
           <Filters
             page={page}
             filters={filters}
diff --git a/public/components/trace_analytics/components/traces/traces_content.tsx b/public/components/trace_analytics/components/traces/traces_content.tsx
index 4744ebee9..82c77641b 100644
--- a/public/components/trace_analytics/components/traces/traces_content.tsx
+++ b/public/components/trace_analytics/components/traces/traces_content.tsx
@@ -252,7 +252,6 @@ export function TracesContent(props: TracesProps) {
               />
             </EuiFlexItem>
           </EuiFlexGroup>
-          {props.filters.length > 0 && <EuiSpacer size="s" />}
           <Filters
             page={page}
             filters={filters}
diff --git a/public/components/trace_analytics/home.tsx b/public/components/trace_analytics/home.tsx
index 8fd06ffff..a18e2baa5 100644
--- a/public/components/trace_analytics/home.tsx
+++ b/public/components/trace_analytics/home.tsx
@@ -296,7 +296,7 @@ export const Home = (props: HomeProps) => {
         path: tracesPath + '?datasourceId=' + dataSourceMDSId[0].id,
       });
     } else {
-      location.assign(tracesPath);
+      location.assign(tracesPath + '?datasourceId=' + dataSourceMDSId[0].id);
     }
 
     setTracesTableMode('traces');