Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Remote Store] Skip downloading segments from remote store if they were written by an incompatible Lucene version #8864

Open
BhumikaSaini-Amazon opened this issue Jul 25, 2023 · 1 comment
Labels
enhancement Enhancement or improvement to existing feature or request Storage:Durability Issues and PRs related to the durability framework Storage Issues and PRs relating to data and metadata storage

Comments

@BhumikaSaini-Amazon
Copy link
Contributor

Is your feature request related to a problem? Please describe.

Today the Lucene version compatibility check for segments downloaded from remote store happens only after all the respective segments have actually been downloaded from the remote store. In the happy path this is fine. But when the Lucene version that wrote the segments currently residing in remote store vs. the Lucene version running on the node are incompatible (currently Lucene supports backward compatibility with 1 major version), this leads to unnecessary resource consumption for downloading the segments.

Describe the solution you'd like
There should to be an optimization which proactively skips downloading segments from remote store unnecessarily if the aforementioned Lucene (major) versions are incompatible.

Describe alternatives you've considered
The Lucene major version information, added to UploadedSegmentMetadata as part of resolving #7722, could be used to decide whether segments should be downloaded or not (i.e. whether the aforementioned Lucene versions are compatible or not).

https://github.com/opensearch-project/OpenSearch/blob/main/server/src/main/java/org/opensearch/index/store/RemoteSegmentStoreDirectory.java#L628-L636

Additional context
Add any other context or screenshots about the feature request here.

@BhumikaSaini-Amazon BhumikaSaini-Amazon added enhancement Enhancement or improvement to existing feature or request untriaged labels Jul 25, 2023
@sachinpkale sachinpkale added Storage:Durability Issues and PRs related to the durability framework and removed untriaged labels Jul 25, 2023
@Bukhtawar Bukhtawar added the Storage Issues and PRs relating to data and metadata storage label Jul 27, 2023
@gulgulni
Copy link

Need to validate how the flow works for the shallow snapshot use case.

@sachinpkale sachinpkale moved this from 🆕 New to Later (6 months plus) in Storage Project Board Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement or improvement to existing feature or request Storage:Durability Issues and PRs related to the durability framework Storage Issues and PRs relating to data and metadata storage
Projects
Status: Later (6 months plus)
Development

No branches or pull requests

4 participants