Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Caching avg total bytes and avg free bytes inside ClusterInfo #15113

Closed
RS146BIJAY opened this issue Aug 5, 2024 · 0 comments
Closed
Labels
bug Something isn't working Indexing:Replication Issues and PRs related to core replication framework eg segrep untriaged

Comments

@RS146BIJAY
Copy link
Contributor

Describe the bug

Description

In case disk usage of a particular node is not populated inside ClusterInfo (due to an underlying issue), we use the average usage for all nodes as the usage for this node inside DiskThresholdDecider. For calculating this value, right now we are iterating through all the diskUsages of every node inside DiskThresholdDecider to calculate total sum and divide by the total number of nodes. Since this computation is performed for each node during shard allocation, it becomes computationally expensive.

Screenshot 2024-07-17 at 10 14 48 AM

Related component

Indexing:Replication

To Reproduce

Create 500k shards on a setup with 1000 data nodes and 3 master nodes.

Expected behavior

Do an offline calculation of Average total bytes and Average free bytes and cache it inside ClusterInfo.

Additional Details

Plugins
Please list all plugins currently enabled.

Screenshots
If applicable, add screenshots to help explain your problem.

Host/Environment (please complete the following information):

  • OS: [e.g. iOS]
  • Version [e.g. 22]

Additional context
Add any other context about the problem here.

@RS146BIJAY RS146BIJAY added bug Something isn't working untriaged labels Aug 5, 2024
@github-actions github-actions bot added the Indexing:Replication Issues and PRs related to core replication framework eg segrep label Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Indexing:Replication Issues and PRs related to core replication framework eg segrep untriaged
Projects
None yet
Development

No branches or pull requests

1 participant