Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] implement mark() in class FilterStreamInput #13096

Closed
kkewwei opened this issue Apr 5, 2024 · 0 comments · Fixed by #13098
Closed

[BUG] implement mark() in class FilterStreamInput #13096

kkewwei opened this issue Apr 5, 2024 · 0 comments · Fixed by #13098
Labels
bug Something isn't working Other v2.14.0 v3.0.0 Issues and PRs related to version 3.0.0

Comments

@kkewwei
Copy link
Contributor

kkewwei commented Apr 5, 2024 •
edited
Loading

Describe the bug

In class FilterStreamInput, we only implement reset(), but don't override mark, it seems not reasonable.

Related component

Other

Additional Details

Host/Environment (please complete the following information):

  • OS: [e.g. iOS]
  • Version [e.g. 22]

Additional context
Add any other context about the problem here.
@kkewwei kkewwei added bug Something isn't working untriaged labels Apr 5, 2024
@github-actions github-actions bot added the Other label Apr 5, 2024
@kkewwei kkewwei mentioned this issue Apr 5, 2024
Merged
8 tasks
@reta reta added v3.0.0 Issues and PRs related to version 3.0.0 v2.14.0 and removed untriaged labels Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working Other v2.14.0 v3.0.0 Issues and PRs related to version 3.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

implement mark() in class FilterStreamInput kkewwei/OpenSearch
2 participants
@reta @kkewwei