-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pluggable extension point for TranslogDeletionPolicy and move CCR specific logic to plugin. #1260
Comments
Instead of creating a separate plugin API for this, we can modify EnginePlugin to provide the extension points. Nick came up with an idea of creating an EngineConfigFactory to solve the issue. |
Reopening it for 1416 |
@adnapibar Thanks for doing these changes.
Individual plugins can still override the translog deletion policy. |
Correct. This avoids the Engine override conflict and enables CCR and KNN to co-exist. This design maintains that only one plugin can override the translog deletion policy. We've discussed the possibility of adding a |
#1100 added translog pruning logic behind an index setting that is specific to CCR. This logic and setting should be scoped only to the CCR plugin.
Suggested solution:
We need to create an extension point for plugins to provide their own TranslogDeletionPolicy logic. Right now we have the limitation that only one plugin may override engine (A suggestion to break this limitation in #1254 ). Until that is available, we should restrict only a single plugin from overriding deletion policy.
The text was updated successfully, but these errors were encountered: