Support Gradle 7 in plugins #1246
Comments
dlvenable
added
the
enhancement
|
@dlvenable picking this one up if you don't mind |
|
Are we going to want to upgrade all plugins? If so after #1609, let's create an issue in https://github.com/opensearch-project/opensearch-plugins/issues similar to opensearch-project/opensearch-plugins#64 and add it to 1.3.0 campaigns? |
|
@dblock yeah, I think we should update all projects to 7.3, I will create the issues shortly, thank you! |
👍 if you want to create sub-issues in each plugin repo too, you can do this by following https://github.com/opensearch-project/opensearch-plugins/blob/main/META.md and the .meta collection for Java plugins in https://github.com/opensearch-project/opensearch-plugins/tree/main/plugins |
|
Sorry @dblock , it is taking me a bit longer to fix all the migration issues, will get to plugins shortly |
Seriously, you're doing amazing work. |
|
@dlvenable #1609 was merged to main, please give it a whirl Thanks @reta! |
|
Thanks a lot @dblock! I tested it on Widows as well, no issues attributed to Gradle 7 :-) |
|
@dblock you would like to see it in 1.x, right? |
Yes, that's why I labeled this "backport 1.x" and the newly added bot made a PR all automagically 🥳 |
|
Thank you for making this change @reta ! @dblock , I tried building Data Prepper on Gradle 7.3 using OpenSearch build-tools 2.0.0-SNAPSHOT. The build succeeded. Data Prepper uses the following Gradle plugins from OpenSearch:
I tried the |
|
@dlvenable thanks a lot for checking, the backport has not been merged just yet, see please #1622, thank you! |
|
@dblock could you please add |
Is your feature request related to a problem? Please describe.
Our Project - DataPrepper - uses OpenSearch Gradle plugins to help us perform integration testing against OpenSearch. The plugins are currently only working on Gradle 6 (I'm unsure of the minimum version in this series).
The plugins use an incubating feature which was introduced in Gradle 6 and changed prior to Gradle 7. The GlobalBuildInfo plugin uses the JavaInstallation class which is not present in Gradle 7.
Describe the solution you'd like
Support Gradle 7 builds. Perhaps also support the later versions of Gradle 6 with the final classes. I believe 6.8.1 may work.
This likely will be a breaking change because it requires consumers of these plugins to update to a newer Gradle version.
For example, index-management uses it.
Additional context
Stack trace when updating DataPrepper to Gradle 7:
The text was updated successfully, but these errors were encountered: