From 197cbec26a85ac7cc56ac65a09591bbc252d4698 Mon Sep 17 00:00:00 2001
From: Bharathwaj G <bharath78910@gmail.com>
Date: Wed, 24 May 2023 23:22:49 +0530
Subject: [PATCH] addressing comments

Signed-off-by: Bharathwaj G <bharath78910@gmail.com>
---
 .../admin/indices/segments/TransportPitSegmentsAction.java | 7 +++----
 .../opensearch/action/search/TransportDeletePitAction.java | 7 +++----
 2 files changed, 6 insertions(+), 8 deletions(-)

diff --git a/server/src/main/java/org/opensearch/action/admin/indices/segments/TransportPitSegmentsAction.java b/server/src/main/java/org/opensearch/action/admin/indices/segments/TransportPitSegmentsAction.java
index 323d9e1e9d131..d843b3a9452a5 100644
--- a/server/src/main/java/org/opensearch/action/admin/indices/segments/TransportPitSegmentsAction.java
+++ b/server/src/main/java/org/opensearch/action/admin/indices/segments/TransportPitSegmentsAction.java
@@ -96,9 +96,6 @@ public TransportPitSegmentsAction(
      */
     @Override
     protected void doExecute(Task task, PitSegmentsRequest request, ActionListener<IndicesSegmentResponse> listener) {
-        // remove pit id duplicates from the request
-        Set<String> pitIdSet = new LinkedHashSet<>(request.getPitIds());
-        request.clearAndSetPitIds(new ArrayList<>(pitIdSet));
         if (request.getPitIds().size() == 1 && "_all".equals(request.getPitIds().get(0))) {
             pitService.getAllPits(ActionListener.wrap(response -> {
                 request.clearAndSetPitIds(response.getPitInfos().stream().map(ListPitInfo::getPitId).collect(Collectors.toList()));
@@ -118,7 +115,9 @@ protected void doExecute(Task task, PitSegmentsRequest request, ActionListener<I
     @Override
     protected ShardsIterator shards(ClusterState clusterState, PitSegmentsRequest request, String[] concreteIndices) {
         final ArrayList<ShardRouting> iterators = new ArrayList<>();
-        for (String pitId : request.getPitIds()) {
+        // remove duplicates from the request
+        Set<String> uniquePitIds = new LinkedHashSet<>(request.getPitIds());
+        for (String pitId : uniquePitIds) {
             SearchContextId searchContext = decode(namedWriteableRegistry, pitId);
             for (Map.Entry<ShardId, SearchContextIdForNode> entry : searchContext.shards().entrySet()) {
                 final SearchContextIdForNode perNode = entry.getValue();
diff --git a/server/src/main/java/org/opensearch/action/search/TransportDeletePitAction.java b/server/src/main/java/org/opensearch/action/search/TransportDeletePitAction.java
index 77e650bb89ef3..217fcc1489df7 100644
--- a/server/src/main/java/org/opensearch/action/search/TransportDeletePitAction.java
+++ b/server/src/main/java/org/opensearch/action/search/TransportDeletePitAction.java
@@ -48,9 +48,6 @@ public TransportDeletePitAction(
      */
     @Override
     protected void doExecute(Task task, DeletePitRequest request, ActionListener<DeletePitResponse> listener) {
-        // remove pit id duplicates from the request
-        Set<String> pitIdSet = new LinkedHashSet<>(request.getPitIds());
-        request.clearAndSetPitIds(new ArrayList<>(pitIdSet));
         if (request.getPitIds().size() == 1 && "_all".equals(request.getPitIds().get(0))) {
             deleteAllPits(listener);
         } else {
@@ -63,7 +60,9 @@ protected void doExecute(Task task, DeletePitRequest request, ActionListener<Del
      */
     private void deletePits(ActionListener<DeletePitResponse> listener, DeletePitRequest request) {
         Map<String, List<PitSearchContextIdForNode>> nodeToContextsMap = new HashMap<>();
-        for (String pitId : request.getPitIds()) {
+        // remove duplicates from the request
+        Set<String> uniquePitIds = new LinkedHashSet<>(request.getPitIds());
+        for (String pitId : uniquePitIds) {
             SearchContextId contextId = SearchContextId.decode(namedWriteableRegistry, pitId);
             for (SearchContextIdForNode contextIdForNode : contextId.shards().values()) {
                 PitSearchContextIdForNode pitSearchContext = new PitSearchContextIdForNode(pitId, contextIdForNode);