Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Navigation-Next] Support nested items in left navigation. #7118

Closed
SuZhou-Joe opened this issue Jun 27, 2024 · 1 comment
Closed

[Navigation-Next] Support nested items in left navigation. #7118

SuZhou-Joe opened this issue Jun 27, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request navigation

Comments

@SuZhou-Joe
Copy link
Member

SuZhou-Joe commented Jun 27, 2024

Is your feature request related to a problem? Please describe.

Slice 3
In the new navigation, we are seeking for a solution to enable nested items for some sub applications within plugins. For the example above, the detection rules and log types are the sub applications we are talking about.

Describe the solution you'd like

Add a new field in ChromeRegistrationNavLink:

export interface ChromeRegistrationNavLink {
  ...,
  parentNavLinkId?: string;
};

core.chrome.addNavLinksToGroup(DEFAULT_NAV_GROUPS.observability, [{ id: 'detectionRule', parentNavLinkId: 'threatDetectors' }]);

And in such case, we are able to support infinite levels of nested menu items if we want.

Describe alternatives you've considered

A clear and concise description of any alternative solutions or features you've considered.

Additional context

#7027

@SuZhou-Joe SuZhou-Joe added the enhancement New feature or request label Jun 27, 2024
@SuZhou-Joe SuZhou-Joe self-assigned this Jul 2, 2024
@SuZhou-Joe
Copy link
Member Author

Has been supported in #7060

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request navigation
Projects
None yet
Development

No branches or pull requests

1 participant