Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MD] Index pattern selector which was used in maps dashboard plugin and visualization should show data source name as prefix #5900

Closed
BionIT opened this issue Feb 20, 2024 · 6 comments · Fixed by #5907
Assignees
Labels

Comments

@BionIT
Copy link
Collaborator

BionIT commented Feb 20, 2024

Is your feature request related to a problem? Please describe.

I feel confused when multiple data source is enabled, while using visualization and need to select an index pattern created from connected data sources, it is almost impossible to distinguish which data source the index pattern belongs to
Screenshot 2024-02-19 at 3 47 33 PM

Describe the solution you'd like

I would want to be able to have the data source connection name as a prefix to the index pattern name, similar to what we have in saved objects page and discover data picker
Screenshot 2024-02-19 at 4 01 47 PM

saved objects page
Screenshot 2024-02-19 at 4 01 17 PM

Describe alternatives you've considered
There is no alternative other than guessing which data source the index pattern belongs to

Additional context

Add any other context or screenshots about the feature request here.

@BionIT BionIT added the enhancement New feature or request label Feb 20, 2024
@BionIT
Copy link
Collaborator Author

BionIT commented Feb 20, 2024

Synced with @kgcreative , and please correct me if it is wrong, the prefix should be like <datasource_name>::<index_pattern_name>

@BionIT
Copy link
Collaborator Author

BionIT commented Feb 20, 2024

Happy to work on this

@BionIT
Copy link
Collaborator Author

BionIT commented Feb 20, 2024

@kgcreative This is what I have for now and should be able to raise PR by end of day if this looks good
Screenshot 2024-02-20 at 10 15 48 AM

@kgcreative
Copy link
Member

Thank you @BionIT! This LGTM!

@seraphjiang
Copy link
Member

Synced with @kgcreative , and please correct me if it is wrong, the prefix should be like <connection_name>::<index_pattern_name>

Sorry for nitpicking, @BionIT @kgcreative

Could we use datasourcename as right term

To be consist with design and other related doc

#1388

https://docs.aws.amazon.com/opensearch-service/latest/developerguide/direct-query-s3-configure.html

@BionIT
Copy link
Collaborator Author

BionIT commented Feb 20, 2024

Thanks @seraphjiang ! Updated the term in my comment

@BionIT BionIT changed the title [MD] Index pattern selector which was used in maps dashboard plugin and visualization should show data source connection name as prefix [MD] Index pattern selector which was used in maps dashboard plugin and visualization should show data source name as prefix Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants