Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v2.12.0] Ensure CI/documentation reflect changes to default admin credentials #5636

Closed
2 tasks
derek-ho opened this issue Dec 21, 2023 · 9 comments
Closed
2 tasks
Assignees
Labels

Comments

@derek-ho
Copy link
Contributor

Background

Previously, when installing the security plugin demo configuration, the cluster was spun up with the default admin credentials, admin:admin. A change was made in main and backported to 2.x for the 2.12.0 release, which now requires an initial admin password to be passed in via the environment variable OPENSEARCH_INITIAL_ADMIN_PASSWORD. This will break some CI/testing that relies on OpenSearch to come up without setting this environment variable. This tracking issue is to ensure compliance with the new changes.

Coming from: opensearch-project/security#3624

Acceptance Criteria

  • All documentation references to the old default credentials admin:admin are removed
  • Ensure that CI/testing is working with main and 2.x branches
@derek-ho
Copy link
Contributor Author

Seems like the only references are for BWC tests: https://github.com/search?q=repo%3Aopensearch-project%2FOpenSearch-Dashboards%20admin%3Aadmin&type=code, latest of which is 2.9.0. I think that makes this repo compliant/I do not see any CI failures on main/2.x either. Can Maintainers confirm if this is the only workflow which relies on admin:admin default creds in this repo? Thanks!

@DarshitChanpura
Copy link
Member

@kavilla are we good to close this issue?

@bbarani
Copy link
Member

bbarani commented Jan 26, 2024

@wbeckler @kavilla @ashwin-pc Can you please provide your updates?

@wbeckler
Copy link

@DarshitChanpura
Copy link
Member

@kavilla I found this:

await execa(OPENSEARCH_SECURITY_INSTALL, ['-y', '-i', '-s'], { cwd: installPath });
which calls the demo config. Do you know what is that used for ?

@kavilla
Copy link
Member

kavilla commented Jan 31, 2024

@kavilla I found this:

await execa(OPENSEARCH_SECURITY_INSTALL, ['-y', '-i', '-s'], { cwd: installPath });

which calls the demo config. Do you know what is that used for ?

local development. developers can pull down this repo, clone the security dashboards plugin. Then from OSD call yarn start:security it will download an OpenSearch snapshot. Install the security plugin, run the demo certs installation, and start it then OpenSearch Dashboards.

If you just want to scale up an OpenSearch cluster with the certs install you can call yarn opensearch snapshot --security

@DarshitChanpura
Copy link
Member

DarshitChanpura commented Jan 31, 2024

Then from OSD call yarn start:security it will download an OpenSearch snapshot. Install the security plugin, run the demo certs installation, and start it then OpenSearch Dashboards.

We should mention that a strong password is required to start the cluster with demo security configuration. Otherwise, when someone attempts to run yarn start:security it will fail.

@kavilla
Copy link
Member

kavilla commented Jan 31, 2024

Then from OSD call yarn start:security it will download an OpenSearch snapshot. Install the security plugin, run the demo certs installation, and start it then OpenSearch Dashboards.

We should mention that a strong password is required to start the cluster with demo security configuration. Otherwise, when someone attempts to run yarn start:security it will fail.

I think we do. Do you think this will suffice @DarshitChanpura?
https://github.com/opensearch-project/OpenSearch-Dashboards/blob/main/DEVELOPER_GUIDE.md#configure-opensearch-dashboards-for-security

@DarshitChanpura
Copy link
Member

@kavilla Yes that should suffice. Marking this as complete via #5736. Feel free to open it if I missed something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants