Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MD] Feature test connection follow up #3060

Closed
5 tasks
kristenTian opened this issue Dec 10, 2022 · 2 comments · Fixed by #3110
Closed
5 tasks

[MD] Feature test connection follow up #3060

kristenTian opened this issue Dec 10, 2022 · 2 comments · Fixed by #3110
Assignees
@zhongnansu
Labels
enhancement New feature or request multiple datasource multiple datasource project v2.5.0 'Issues and PRs related to version v2.5.0'

Comments

@kristenTian
Copy link
Contributor

kristenTian commented Dec 10, 2022 •
edited by zhongnansu
Loading

Given the author is not able to continue follow up on the original code in #2973, and the team still prefer to pick this up, creating sub issues to work incrementally and track the feature & backport.

  • Discuss and address the comments.
  • Update UT(UT that previous skipped to unblock PR merge).
  • Handling 403 error case.
  • replace empty datasource id with undefined
  • improve error handling (not return 500 in this edit case)
@kristenTian kristenTian added the multiple datasource multiple datasource project label Dec 10, 2022
@kristenTian kristenTian mentioned this issue Dec 10, 2022
Merged
8 tasks
@zhongnansu
Copy link
Member

zhongnansu commented Dec 13, 2022 •
edited
Loading

  • improve error handling (not return 500 in this edit case)

image

@kristenTian
Copy link
Contributor Author

Is there no error message toast to user in edit data source page?

@zhongnansu zhongnansu added the enhancement New feature or request label Dec 13, 2022
@zhongnansu zhongnansu self-assigned this Dec 13, 2022
@zhongnansu zhongnansu mentioned this issue Dec 20, 2022
Merged
8 tasks
@kavilla kavilla linked a pull request Dec 20, 2022 that will close this issue
[MD] Improve test connection #3110
Merged
8 tasks
@zhongnansu zhongnansu added the v2.5.0 'Issues and PRs related to version v2.5.0' label Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zhongnansu zhongnansu

Labels
enhancement New feature or request multiple datasource multiple datasource project v2.5.0 'Issues and PRs related to version v2.5.0'
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[MD] Improve test connection zhongnansu/OpenSearch-Dashboards
2 participants
@zhongnansu @kristenTian