Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve permission denied message #1815

Open
fioddor opened this issue Jun 29, 2022 · 6 comments
Open

Improve permission denied message #1815

fioddor opened this issue Jun 29, 2022 · 6 comments
Labels
enhancement New feature or request

Comments

@fioddor
Copy link

fioddor commented Jun 29, 2022

Is your feature request related to a problem? Please describe.

Users without write access to .kibana index are offered the Edit opition and others they are not really entitled to use.

Once they ask to save or edit a panel an 'Application Not Found' error is shown.

This message doesn't provide useful clues.

Describe the solution you'd like

The best solution would be to rethink the user experience.

Describe alternatives you've considered

Improving the message adding a "You might perhaps lack the needed permissions?" should suffice and go a long way already.

Additional context

image

@fioddor fioddor added the enhancement New feature or request label Jun 29, 2022
@CPTNB
Copy link
Contributor

CPTNB commented Jun 29, 2022

Hi, what action were you trying to perform when this error surfaced? I agree, this message should be a permission denied message instead of a not found message.

Related error UX ticket: #1625

@joshuarrrr
Copy link
Member

Just an additional note - that loading spinner should not appear on top of the error message.

@kavilla
Copy link
Member

kavilla commented Jun 29, 2022

Should we re-route this to the security plugin @CPTNB? From OpenSearch Dashboards Core perspective it attempted to read the system index and the security plugin intercepted and filtered that component out so from our side of the app we think we showing the right message.

@CPTNB
Copy link
Contributor

CPTNB commented Jun 29, 2022

Oh, the security plugin doesn't give us an unauthorized indication? Sounds like we'd need to get a change in both the security plugin and core to (1) know it's an auth issue, and (2) display an auth error.

@joshuarrrr
Copy link
Member

Also related to #1782

@fioddor
Copy link
Author

fioddor commented Sep 20, 2023

Oh, the security plugin doesn't give us an unauthorized indication? Sounds like we'd need to get a change in both the security plugin and core to (1) know it's an auth issue, and (2) display an auth error.

In the first place, users without write access to .kibana index shouldn't be offered the Edit option or other options they are not entitled to use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants