From bdb1241340fc2fd0296e974c3fd9e77bdddb2037 Mon Sep 17 00:00:00 2001 From: Peter Nied Date: Tue, 28 Sep 2021 10:21:24 -0500 Subject: [PATCH 1/4] Developer Certificate of Origin workflow Signed-off-by: Peter Nied --- workflow/dco.yml | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) create mode 100644 workflow/dco.yml diff --git a/workflow/dco.yml b/workflow/dco.yml new file mode 100644 index 00000000000..6b1b4a4ae43 --- /dev/null +++ b/workflow/dco.yml @@ -0,0 +1,18 @@ +name: Developer Certificate of Origin Check + +on: [pull_request] + +jobs: + build: + runs-on: ubuntu-latest + + steps: + - name: Get PR Commits + id: 'get-pr-commits' + uses: tim-actions/get-pr-commits@master + with: + token: ${{ secrets.GITHUB_TOKEN }} + - name: DCO Check + uses: tim-actions/dco@master + with: + commits: ${{ steps.get-pr-commits.outputs.commits }} \ No newline at end of file From ead8cc94ece128b980e9ae1ce549fe472b32328b Mon Sep 17 00:00:00 2001 From: Peter Nied Date: Tue, 28 Sep 2021 12:23:27 -0500 Subject: [PATCH 2/4] Add documentation for DCO workflow Signed-off-by: Peter Nied --- MAINTAINERS.md | 8 ++++++++ workflow/dco.yml | 6 +++--- 2 files changed, 11 insertions(+), 3 deletions(-) diff --git a/MAINTAINERS.md b/MAINTAINERS.md index 22f1123c3b0..d9d8982ce68 100644 --- a/MAINTAINERS.md +++ b/MAINTAINERS.md @@ -57,6 +57,14 @@ Respond to enhancement requests, and forum posts. Allocate time to reviewing and Keep the `main` branch at production quality at all times. Backport features as needed. Cut release branches and tags to enable future patches. +### Add Continious Integration Checks + +Add integration checks that validate pull requests and pushes to ease the burden on Pull Request reviewers + +#### Developer Certificate of Origin workflow + +Validates pull requests commits are all signed with the doc, [doc.yml](./workflow/doc.yml). Example [pull request](https://github.com/opensearch-project/opensearch-ci/pull/16). + ### Use Semver Use and enforce [semantic versioning](https://semver.org/) and do not let breaking changes be made outside of major releases. diff --git a/workflow/dco.yml b/workflow/dco.yml index 6b1b4a4ae43..d4c9ff2c486 100644 --- a/workflow/dco.yml +++ b/workflow/dco.yml @@ -3,16 +3,16 @@ name: Developer Certificate of Origin Check on: [pull_request] jobs: - build: + check: runs-on: ubuntu-latest steps: - name: Get PR Commits id: 'get-pr-commits' - uses: tim-actions/get-pr-commits@master + uses: tim-actions/get-pr-commits@v1.1.0 with: token: ${{ secrets.GITHUB_TOKEN }} - name: DCO Check - uses: tim-actions/dco@master + uses: tim-actions/dco@v1.1.0 with: commits: ${{ steps.get-pr-commits.outputs.commits }} \ No newline at end of file From f4d216605cba309ed09fcaa308c6b248cb2ffbd6 Mon Sep 17 00:00:00 2001 From: Peter Nied Date: Tue, 28 Sep 2021 15:11:17 -0500 Subject: [PATCH 3/4] PR comments Signed-off-by: Peter Nied --- MAINTAINERS.md | 28 ++++++++++++++++------------ 1 file changed, 16 insertions(+), 12 deletions(-) diff --git a/MAINTAINERS.md b/MAINTAINERS.md index d9d8982ce68..2734b920d7d 100644 --- a/MAINTAINERS.md +++ b/MAINTAINERS.md @@ -1,16 +1,20 @@ - [Overview](#overview) - [Current Maintainers](#current-maintainers) - [Maintainer Responsibilities](#maintainer-responsibilities) - - [Uphold Code of Conduct](#uphold-code-of-conduct) - - [Prioritize Security](#prioritize-security) - - [Review Pull Requests](#review-pull-requests) - - [Triage Open Issues](#triage-open-issues) - - [Be Responsive](#be-responsive) - - [Maintain Overall Health of the Repo](#maintain-overall-health-of-the-repo) - - [Use Semver](#use-semver) - - [Release Frequently](#release-frequently) - - [Promote Other Maintainers](#promote-other-maintainers) - - [Describe the Repo](#describe-the-repo) + * [Uphold Code of Conduct](#uphold-code-of-conduct) + * [Prioritize Security](#prioritize-security) + * [Review Pull Requests](#review-pull-requests) + * [Triage Open Issues](#triage-open-issues) + * [Be Responsive](#be-responsive) + * [Maintain Overall Health of the Repo](#maintain-overall-health-of-the-repo) + * [Add Continious Integration Checks](#add-continious-integration-checks) + + [Developer Certificate of Origin workflow](#developer-certificate-of-origin-workflow) + * [Use Semver](#use-semver) + * [Release Frequently](#release-frequently) + * [Promote Other Maintainers](#promote-other-maintainers) + * [Describe the Repo](#describe-the-repo) + +Table of contents generated with markdown-toc ## Overview @@ -59,9 +63,9 @@ Keep the `main` branch at production quality at all times. Backport features as ### Add Continious Integration Checks -Add integration checks that validate pull requests and pushes to ease the burden on Pull Request reviewers +Add integration checks that validate pull requests and pushes to ease the burden on Pull Request reviewers. -#### Developer Certificate of Origin workflow +#### Developer Certificate of Origin Workflow Validates pull requests commits are all signed with the doc, [doc.yml](./workflow/doc.yml). Example [pull request](https://github.com/opensearch-project/opensearch-ci/pull/16). From a7352e18e963f6f37b6039f44926cb1427e484ea Mon Sep 17 00:00:00 2001 From: Peter Nied Date: Tue, 28 Sep 2021 16:01:24 -0500 Subject: [PATCH 4/4] Redo formating Signed-off-by: Peter Nied --- MAINTAINERS.md | 26 ++++++++++++-------------- 1 file changed, 12 insertions(+), 14 deletions(-) diff --git a/MAINTAINERS.md b/MAINTAINERS.md index 2734b920d7d..45ed2f3991f 100644 --- a/MAINTAINERS.md +++ b/MAINTAINERS.md @@ -1,20 +1,18 @@ - [Overview](#overview) - [Current Maintainers](#current-maintainers) - [Maintainer Responsibilities](#maintainer-responsibilities) - * [Uphold Code of Conduct](#uphold-code-of-conduct) - * [Prioritize Security](#prioritize-security) - * [Review Pull Requests](#review-pull-requests) - * [Triage Open Issues](#triage-open-issues) - * [Be Responsive](#be-responsive) - * [Maintain Overall Health of the Repo](#maintain-overall-health-of-the-repo) - * [Add Continious Integration Checks](#add-continious-integration-checks) - + [Developer Certificate of Origin workflow](#developer-certificate-of-origin-workflow) - * [Use Semver](#use-semver) - * [Release Frequently](#release-frequently) - * [Promote Other Maintainers](#promote-other-maintainers) - * [Describe the Repo](#describe-the-repo) - -Table of contents generated with markdown-toc + - [Uphold Code of Conduct](#uphold-code-of-conduct) + - [Prioritize Security](#prioritize-security) + - [Review Pull Requests](#review-pull-requests) + - [Triage Open Issues](#triage-open-issues) + - [Be Responsive](#be-responsive) + - [Maintain Overall Health of the Repo](#maintain-overall-health-of-the-repo) + - [Add Continious Integration Checks](#add-continious-integration-checks) + - [Developer Certificate of Origin Workflow](#developer-certificate-of-origin-workflow) + - [Use Semver](#use-semver) + - [Release Frequently](#release-frequently) + - [Promote Other Maintainers](#promote-other-maintainers) + - [Describe the Repo](#describe-the-repo) ## Overview