Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating Terminal Attributes after updating name of VoltageLevel or Bay #674

Closed
dlabordus opened this issue Apr 6, 2022 · 0 comments · Fixed by #712
Closed

Updating Terminal Attributes after updating name of VoltageLevel or Bay #674

dlabordus opened this issue Apr 6, 2022 · 0 comments · Fixed by #712
Assignees
Labels
Kind: Bug Something isn't working Status: Ready for development Checked by all co-developers

Comments

@dlabordus
Copy link
Contributor

Describe the bug
When updating the name of a Bay or VoltageLevel these names are also registered as BayName/VoltageLevelName by Terminals.
These attributes of the Terminal aren't updated.
In PR #671 this is solved for the name of the Substation, the strange thing is that this cause problems when validating the XML, for Bay and VoltageLevel this isn't cause any validation problems.

To Reproduce
Steps to reproduce the behavior:

  1. Open a SCD with Substation, VoltageLevel, Bay and Terminal(s), where there is a reference in Terminal to the different levels.
  2. Update the name of the VoltageLevel and Bay.
  3. Save the file and check if the attributes in the terminal are updated.

Expected behavior
The attributes in the Terminal should be updated

Additional context
Example part where the attributes aren't updated:

<Substation name="AA1-UPD" desc="Substation" sxy:x="1" sxy:y="3">
	<VoltageLevel sxy:x="1" sxy:y="3" name="J1-UPD" desc="Voltage Level">
		<Voltage unit="V" multiplier="k">20</Voltage>
		<Bay sxy:x="1" sxy:y="6" name="Bay A-UPD" desc="Feld A">
			<ConductingEquipment type="DIS" sxy:x="1" sxy:y="1" name="QB1">
				<Terminal name="T3" connectivityNode="AA1/J1/Bay A/L1" substationName="AA1" voltageLevelName="J1" bayName="Bay A" cNodeName="L1" txy:actTerm="2"/>
			</ConductingEquipment>
@dlabordus dlabordus added the Kind: Bug Something isn't working label Apr 6, 2022
@dlabordus dlabordus changed the title Updating Terminal Attributes after updating name of VoltagerLevel or Bay Updating Terminal Attributes after updating name of VoltageLevel or Bay Apr 6, 2022
@Sander3003 Sander3003 added the Status: Ready for development Checked by all co-developers label Apr 11, 2022
@JakobVogelsang JakobVogelsang added this to the Sprint 2022-04-29 milestone Apr 25, 2022
@dlabordus dlabordus self-assigned this Apr 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Kind: Bug Something isn't working Status: Ready for development Checked by all co-developers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants