Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(validatetemplates): don't require "Oper" if ctlModel=status-only #269

Merged
merged 2 commits into from
Jul 27, 2021
Merged

fix(validatetemplates): don't require "Oper" if ctlModel=status-only #269

merged 2 commits into from
Jul 27, 2021

Conversation

ca-d
Copy link
Contributor

@ca-d ca-d commented Jul 26, 2021

Closes #268 .

@ca-d ca-d added Kind: Bug Something isn't working Reviewed: Prioritized Priority: Important Tackle eventually labels Jul 26, 2021
@ca-d ca-d added this to the Sprint 2021-07-30 milestone Jul 26, 2021
@ca-d ca-d requested a review from JakobVogelsang July 26, 2021 11:50
@ca-d ca-d self-assigned this Jul 26, 2021
JakobVogelsang
JakobVogelsang reviewed Jul 27, 2021
View reviewed changes
Copy link
Collaborator

@JakobVogelsang JakobVogelsang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the effort with this most likely annoying bug fix!
Some strings can be more precise, but other than that, LGTM.

src/translations/de.ts Outdated Show resolved Hide resolved
src/translations/en.ts Outdated Show resolved Hide resolved
src/translations/en.ts Outdated Show resolved Hide resolved
@JakobVogelsang JakobVogelsang marked this pull request as ready for review July 27, 2021 08:37
@ca-d ca-d marked this pull request as draft July 27, 2021 09:22
@JakobVogelsang JakobVogelsang marked this pull request as ready for review July 27, 2021 12:50
@JakobVogelsang JakobVogelsang merged commit 2cef3d7 into main Jul 27, 2021
@ca-d ca-d deleted the fix-missing-ctlmodel-errors branch August 2, 2021 10:43
Stef3st pushed a commit that referenced this pull request Nov 2, 2023
@juancho0202
Merge pull request #269 from com-pas/dependabot/github_actions/docker…
36a7897 
…/login-action-3

chore(deps): bump docker/login-action from 2 to 3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JakobVogelsang JakobVogelsang JakobVogelsang left review comments

Assignees

@ca-d ca-d

Labels
Kind: Bug Something isn't working Priority: Important Tackle eventually
Projects
None yet
Milestone
Sprint 2021-07-30
Development

Successfully merging this pull request may close these issues.

fix(validatetemplates): don't require "Oper" if ctlModel=status-only
2 participants
@ca-d @JakobVogelsang