Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(editors/templates/lnodetype-wizards): add basic lnodetype manipulation capabilities #213

Merged
merged 6 commits into from
Jun 15, 2021

Conversation

JakobVogelsang
Copy link
Collaborator

Closes #211

@JakobVogelsang JakobVogelsang added this to the Sprint 2021-06-11 milestone Jun 8, 2021
@ca-d ca-d force-pushed the show-lnotetypes-in-template-editor branch 2 times, most recently from f50e0db to 6180acc Compare June 11, 2021 15:37
@ca-d ca-d changed the base branch from show-lnotetypes-in-template-editor to main June 11, 2021 16:04
@JakobVogelsang JakobVogelsang force-pushed the add-basic-lnodetype-manipulation-capabilities branch from 79b87b4 to 3d10564 Compare June 14, 2021 11:26
@JakobVogelsang JakobVogelsang marked this pull request as ready for review June 15, 2021 07:02
@JakobVogelsang JakobVogelsang requested a review from ca-d June 15, 2021 07:02
Copy link
Contributor

@ca-d ca-d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -48,10 +49,26 @@ export function updateIDNamingAction(element: Element): WizardActor {
};
}

function isActionUnique(actions: Create[], newAction: Create): boolean {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this could be renamed to containsCreateAction(actions: Create[], action: Create): boolean?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a better name, I agree! Thanks

@JakobVogelsang JakobVogelsang changed the title Add basic lnodetype manipulation capabilities feat(editors/templates/lnodetype-wizards): add basic lnodetype manipulation capabilities Jun 15, 2021
@JakobVogelsang JakobVogelsang merged commit 48a3753 into main Jun 15, 2021
@ca-d ca-d deleted the add-basic-lnodetype-manipulation-capabilities branch June 17, 2021 07:31
pascalwilbrink pushed a commit that referenced this pull request Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Kind: Enhancement New Request Priority: Important Tackle eventually
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add basic LNodeType manipulation capabilit
2 participants