-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Added XML Package for OpenSCD #1536
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks well executed in the extraction, my only concern is that the migrated tests from packages/open-scd
to packages/xml
are not being executed because there is no test script and no devDependency on "@web/test-runner" at the @openscd/xml
project.
If you add that missing bit this is complete imo.
b1f3b28
to
2263389
Compare
2d97abd
to
29cd493
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am approving because I think it's done, just needs the removal of the duplicated CONTRIBUTING guide but functional and code wise it's done.
No description provided.