Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Moved towards get function from lit-translate #1471

Merged
merged 4 commits into from
Mar 15, 2024
Merged

Fix: Moved towards get function from lit-translate #1471

merged 4 commits into from
Mar 15, 2024

Conversation

pascalwilbrink
Copy link
Member

@pascalwilbrink pascalwilbrink commented Mar 12, 2024 •
edited
Loading

Fixes #1470

Stef3st
Stef3st suggested changes Mar 15, 2024
View reviewed changes
Copy link
Contributor

@Stef3st Stef3st left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, it seems pretty straight forward. I checked the files and found 1 where the translate got changed incorrectly. There are still some other tests that fail, but I havent found any errors in the code changes other then the 1 below.

Stef3st
Stef3st approved these changes Mar 15, 2024
View reviewed changes
Copy link
Contributor

@Stef3st Stef3st left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Stef3st Stef3st merged commit 03dabf9 into main Mar 15, 2024
5 checks passed
@Stef3st Stef3st deleted the Lit_Translate_Get branch March 15, 2024 09:49
@github-actions github-actions bot mentioned this pull request Mar 19, 2024
Closed
@github-actions github-actions bot mentioned this pull request Jun 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Stef3st Stef3st Stef3st approved these changes

@juancho0202 juancho0202 Awaiting requested review from juancho0202

Assignees
No one assigned
Labels
None yet
Projects
PR Overview
Status: Approved
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Lit translate to make use of get instead of translate
2 participants
@pascalwilbrink @Stef3st