Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add node release type and core path #1437

Merged
merged 3 commits into from
Feb 19, 2024

Conversation

Stef3st
Copy link
Contributor

@Stef3st Stef3st commented Feb 12, 2024

closes #1433

Signed-off-by: Stef3st <steffen.van.den.driest@alliander.com>
@Stef3st Stef3st linked an issue Feb 12, 2024 that may be closed by this pull request
@Stef3st
Copy link
Contributor Author

Stef3st commented Feb 12, 2024

I've added the core package as path for triggering the workflow. Besides that Ive added the node release type so that a release PR gets made where a changelog.md will be added/updated and the package.json version will be updated. Im not a 100% sure if the package.json of the core will be updated or the one in the root. Its hard to find good documentation on that part and its hard to test it.

Co-authored-by: Pascal Wilbrink <pascal.wilbrink@alliander.com>
@Stef3st Stef3st merged commit d1bde4e into main Feb 19, 2024
4 checks passed
@Stef3st Stef3st deleted the 1433-fix-release-please-workflow branch February 19, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Fix release-please workflow
2 participants