Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display LN describtion #1431

Closed
Sander3003 opened this issue Feb 5, 2024 · 6 comments
Closed

Display LN describtion #1431

Sander3003 opened this issue Feb 5, 2024 · 6 comments
Labels

Comments

@Sander3003
Copy link
Member

Is your feature request related to a problem? Please describe.
As a user of OpenSCD I want to show the LN describtion in the IED browser
So I can understand the LN better

Describe the solution you'd like
An edit button on the LN's in the IED browser:
image

And an dialog to show and edit the describtion.

Requirements
Show and edit LN description fields

Additional information
desc is part of the SCL XSD's

image

Test Files
If possible provide a file that can be used to test the feature and explain what is the outcome of the test with the test file

@Sander3003 Sander3003 added the Kind: Enhancement New Request label Feb 5, 2024
@DavoodSooran
Copy link
Collaborator

@Sander3003 Sure I will work on it.

@DavoodSooran
Copy link
Collaborator

DavoodSooran commented Feb 15, 2024

see the link below:

#1465

@JakobVogelsang
Copy link
Collaborator

Hi you two. I would like to comment on this:

  1. I am seeing two-story descriptions and find it very irritating. If the story description is not sufficient we can edit it and when it is hard to adopt I would open a new one and point from this one that it is handled in the new issue. For the reviewer, it is crucial to have a straight forward reference to review against.
  2. The wizard that is see is for the element LNode as well as the table with the attributes. The element shown in the SCL is the element LN and I would add LN0 as well just as they are close code wise. Now it makes sense to add the description field in the wizard of all three of the element, but I would then split those up.

@Sander3003
Copy link
Member Author

Agree @JakobVogelsang it is confunsing to create an new issues if the one is around the same topic.

@DavoodSooran
Copy link
Collaborator

@Sander3003 Jakob's comment is related to the scenario I added beneath this story. Using Jakob's feedback, I crafted a new narrative addressing the concerns raised in the comment.

@Sander3003
Copy link
Member Author

Sander3003 commented Mar 12, 2024

This story will replace this issue: #1465

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants