Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(104): validate IOA number in address-wizard #1370

Merged
merged 8 commits into from
Nov 27, 2023

Conversation

juancho0202
Copy link
Contributor

Closes #1348

Signed-off-by: Juan Munoz <juancho0202@gmail.com>
Signed-off-by: Juan Munoz <juancho0202@gmail.com>
juancho0202 and others added 3 commits November 21, 2023 13:45
Signed-off-by: Juan Munoz <juancho0202@gmail.com>
Signed-off-by: Juan Munoz <juancho0202@gmail.com>
@juancho0202 juancho0202 requested a review from Stef3st November 27, 2023 09:31
Copy link
Contributor

@Stef3st Stef3st left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and works proper! I just have a few question here. Could you maybe elaborate?

Signed-off-by: Juan Munoz <juancho0202@gmail.com>
Signed-off-by: Juan Munoz <juancho0202@gmail.com>
Copy link
Contributor

@Stef3st Stef3st left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@juancho0202 juancho0202 merged commit dff67ba into main Nov 27, 2023
@juancho0202 juancho0202 deleted the 1348-ioa-address-validation branch November 27, 2023 12:22
@github-actions github-actions bot mentioned this pull request Dec 19, 2023
@github-actions github-actions bot mentioned this pull request Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Assigning the same IOA addrees for Mapping DA of a CDC to a 104 Point
2 participants