Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(wizards/doTypes): Adjust regular expressions for v flag in template editor #1273

Merged
merged 5 commits into from
Jun 26, 2023
Merged

fix(wizards/doTypes): Adjust regular expressions for v flag in template editor #1273

merged 5 commits into from
Jun 26, 2023

Conversation

danyill
Copy link
Collaborator

@danyill danyill commented Jun 22, 2023

Closes #1271

@danyill danyill changed the title fix: Fix regular expression warnings in template editor fix: Adjust regular expressions for v flag in template editor Jun 22, 2023
@danyill
Copy link
Collaborator Author

danyill commented Jun 23, 2023

These tests pass locally but I am struggling to convince CI to agree with me.
I think the snapshots are regenerated and correct am surprised to see them failing.
I regenerated the package-lock.json because this seemed to help locally (I could make them fail with an npm ci but not an npm i).

@danyill danyill requested review from Stef3st and ca-d June 23, 2023 06:49
@Stef3st
Copy link
Contributor

Stef3st commented Jun 23, 2023

@danyill when snapshots are created prettier gets called and unfortunatly removes the escape characters. In the previous ticket I fixed this with a workaround by ignoring the patterns in the snapshots and test them individually. You can check it out in the closed PR (#1266).

@danyill danyill force-pushed the issue-1271-regex-warnings branch from 0eb0ce0 to 0eb090f Compare June 23, 2023 21:05
@danyill danyill force-pushed the issue-1271-regex-warnings branch from 0eb090f to 5b2c82a Compare June 24, 2023 17:59
@danyill
Copy link
Collaborator Author

danyill commented Jun 24, 2023

@danyill when snapshots are created prettier gets called and unfortunatly removes the escape characters. In the previous ticket I fixed this with a workaround by ignoring the patterns in the snapshots and test them individually. You can check it out in the closed PR (#1266).

That was exactly the hint I needed and should have noticed on that PR previously. Thanks!

@danyill danyill changed the title fix: Adjust regular expressions for v flag in template editor fix(wizards/doTypes): Adjust regular expressions for v flag in template editor Jun 24, 2023
Stef3st
Stef3st approved these changes Jun 26, 2023
View reviewed changes
Copy link
Contributor

@Stef3st Stef3st left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@danyill danyill merged commit baa9bdc into openscd:main Jun 26, 2023
@danyill
Copy link
Collaborator Author

danyill commented Jun 26, 2023

Thanks for the review 👏

@github-actions github-actions bot mentioned this pull request Mar 19, 2024
Closed
@github-actions github-actions bot mentioned this pull request Jun 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Stef3st Stef3st Stef3st approved these changes

@ca-d ca-d Awaiting requested review from ca-d

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Regex console warning errors in template editor
2 participants
@danyill @Stef3st