From b5e2621e19858aa49d7d40c198fd54495e179051 Mon Sep 17 00:00:00 2001 From: danyill Date: Mon, 13 Sep 2021 22:44:58 +1200 Subject: [PATCH] fix(translation): improve capitalization add missing menu.new (#307) * Improve capitalization in some cases, correct typos in English, add translation for menu.new, closes #306 * Update snapshots --- .../BDA wizarding editing integration.md | 52 ++++++++++++++--- .../DA wizarding editing integration.md | 56 +++++++++++++++---- src/translations/de.ts | 1 + src/translations/en.ts | 9 +-- src/wizards/controlwithiedname.ts | 2 +- .../templates/lnodetype-wizard.test.ts | 4 +- 6 files changed, 97 insertions(+), 27 deletions(-) diff --git a/__snapshots__/BDA wizarding editing integration.md b/__snapshots__/BDA wizarding editing integration.md index 321e1e3dd..337f96715 100644 --- a/__snapshots__/BDA wizarding editing integration.md +++ b/__snapshots__/BDA wizarding editing integration.md @@ -2,12 +2,21 @@ ## `defines a editBDaWizard to edit an existing BDA` -#### `looks like the latest snapshot` +#### `looks like the latest snapshot` ```html - +
- + - + - + + ``` ## `defines a createBDaWizard to create a new BDA element` -#### `looks like the latest snapshot` +#### `looks like the latest snapshot` ```html - +
- + - + + ``` + diff --git a/__snapshots__/DA wizarding editing integration.md b/__snapshots__/DA wizarding editing integration.md index a87ada697..f01c09241 100644 --- a/__snapshots__/DA wizarding editing integration.md +++ b/__snapshots__/DA wizarding editing integration.md @@ -2,12 +2,21 @@ ## `defines a editDaWizard to edit an existing DA` -#### `looks like the latest snapshot` +#### `looks like the latest snapshot` ```html - +
- + - + - + @@ -866,14 +884,19 @@ > + ``` ## `defines a createDaWizard to create a new DA element` -#### `looks like the latest snapshot` +#### `looks like the latest snapshot` ```html - +
- + - + @@ -1658,4 +1690,6 @@ > + ``` + diff --git a/src/translations/de.ts b/src/translations/de.ts index 48b3fed2b..851c3f470 100644 --- a/src/translations/de.ts +++ b/src/translations/de.ts @@ -44,6 +44,7 @@ export const de: Translations = { showieds: 'Zeige IEDs im Substation-Editor', }, menu: { + new: 'Neues projekt', title: 'MenĂ¼', viewLog: 'Protokoll anzeigen', viewDiag: 'Daignose anzeigen', diff --git a/src/translations/en.ts b/src/translations/en.ts index 3fb439c29..ba8655582 100644 --- a/src/translations/en.ts +++ b/src/translations/en.ts @@ -19,13 +19,13 @@ export const en = { sAddr: 'Short address', valKind: 'Value kind', valImport: 'Import value', - fc: 'Function contraint', + fc: 'Function constraint', LNodeType: 'Logical Node Type', - lnClass: 'Logical node class', + lnClass: 'Logical Node Class', accessControl: 'Access control', transient: 'Transient data', Val: 'Default value', - dchg: 'Triggre on data change', + dchg: 'Trigger on data change', qchg: 'Trigger on quality change', dupd: 'Trigger on data update', fixedOffs: 'Fixed offset', @@ -42,6 +42,7 @@ export const en = { showieds: 'Show IEDs in substation editor', }, menu: { + new: 'New project', title: 'Menu', viewLog: 'View log', viewDiag: 'View diagnostics', @@ -283,7 +284,7 @@ export const en = { wizard: { primary: 'Guess content', title: 'Select control model (ctlModel)', - description: `IEDs often contain more controlable logical nodes than switch gear in the field. \n You can select the control model(s) used specific for switch gear.`, + description: `IEDs often contain more controllable logical nodes than switchgear in the field. \n You can select the control model(s) used specific for switchgear.`, }, }, merge: { diff --git a/src/wizards/controlwithiedname.ts b/src/wizards/controlwithiedname.ts index eddf6dec5..2763edaaa 100644 --- a/src/wizards/controlwithiedname.ts +++ b/src/wizards/controlwithiedname.ts @@ -173,7 +173,7 @@ export function selectExtRefsWizard( title: cbId + ' - ' + iedName, primary: { icon: 'delete', - label: get('disconnect'), // FIXME: translate + label: get('disconnect'), action: disconnect(sinkExtRefs), }, secondary: { diff --git a/test/integration/editors/templates/lnodetype-wizard.test.ts b/test/integration/editors/templates/lnodetype-wizard.test.ts index 47c3dafe0..b602cb54f 100644 --- a/test/integration/editors/templates/lnodetype-wizard.test.ts +++ b/test/integration/editors/templates/lnodetype-wizard.test.ts @@ -315,7 +315,7 @@ describe('LNodeType wizards', () => { ) ).to.not.exist; }); - it('adds new lnodetype with corrrect id and lnClass', async () => { + it('adds new LNodeType with correct id and lnClass', async () => { beh.value = ensId; enaOpn.value = spsId; enaCls.value = spsId; @@ -331,7 +331,7 @@ describe('LNodeType wizards', () => { ) ).to.exist; }); - it('adds selected DOs to new lnodetype', async () => { + it('adds selected DOs to new LNodeType', async () => { beh.value = ensId; enaOpn.value = spsId; enaCls.value = spsId;