Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

StackoverflowException occurs #4299

Closed
Jenson3210 opened this issue Jul 4, 2024 · 1 comment · Fixed by #4300
Closed

StackoverflowException occurs #4299

Jenson3210 opened this issue Jul 4, 2024 · 1 comment · Fixed by #4300
Labels
bug Something isn't working

Comments

@Jenson3210
Copy link
Contributor

https://github.com/openrewrite/rewrite/blame/d3e05f186e5bba28a204923bd469462fbbaafd9f/rewrite-gradle/src/main/java/org/openrewrite/gradle/UpgradeDependencyVersion.java#L718

In case of a circular dependency (we think), we see a stackOverflowException.
This was not there until recently (as this block is new)

Will only have time tomorrow for PR/fix/investigation, so if anyone else can fix sooner, feel free 😄
Also, did not come up with a test case yet with outside world libraries...
If anyone knows outside world circular dependency libraries, feel free to comment! 😄
@timtebeek timtebeek added the bug Something isn't working label Jul 4, 2024
@timtebeek timtebeek moved this to Backlog in OpenRewrite Jul 4, 2024
@timtebeek
Copy link
Contributor

/cc @sambsnyd

@Jenson3210 Jenson3210 mentioned this issue Jul 4, 2024
Merged
@github-project-automation github-project-automation bot moved this from Backlog to Done in OpenRewrite Jul 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
OpenRewrite
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Resolved stackoverflow exception for circular dependencies.
2 participants
@timtebeek @Jenson3210