JUnit4to5Migration uses old mockito-junit-jupiter version

[Saturas89]

The added dependency from mockito-junit-jupiter could be upgraded to a newer one.

How are you running OpenRewrite?

I am using the Maven plugin, and my project is a single module project.

<plugin>
  <groupId>org.openrewrite.maven</groupId>
  <artifactId>rewrite-maven-plugin</artifactId>
  <version>5.34.1</version>
  <configuration>
   <activeRecipes>
       <recipe>org.openrewrite.java.testing.junit5.JUnit4to5Migration</recipe>
    </activeRecipes>
   </configuration>
         <dependencies>
          <dependency>
           <groupId>org.openrewrite.recipe</groupId>
           <artifactId>rewrite-testing-frameworks</artifactId>
            <version>2.12.2</version>
           </dependency>
          </dependencies>
</plugin>

What did you expect to see?

      <dependency>
            <groupId>org.mockito</groupId>
            <artifactId>mockito-junit-jupiter</artifactId>
            <version>5.12.0</version>
            <scope>test</scope>
        </dependency>

What did you see instead?

      <dependency>
            <groupId>org.mockito</groupId>
            <artifactId>mockito-junit-jupiter</artifactId>
            <version>3.12.4</version>
            <scope>test</scope>
        </dependency>

[timtebeek]

Hi! Thanks for the report; looks like we indeed bump to 3.x in two locations:

Once as part of org.openrewrite.java.testing.junit5.JUnit4to5Migration

rewrite-testing-frameworks/src/main/resources/META-INF/rewrite/junit5.yml

Lines 130 to 136 in fd0eb2d

	- org.openrewrite.java.dependencies.AddDependency:
	groupId: org.mockito
	artifactId: mockito-junit-jupiter
	version: 3.x
	onlyIfUsing: org.mockito..*
	acceptTransitive: true
	scope: test

And once more via org.openrewrite.java.testing.mockito.Mockito1to3Migration

rewrite-testing-frameworks/src/main/resources/META-INF/rewrite/mockito.yml

Lines 136 to 141 in fd0eb2d

	- org.openrewrite.java.dependencies.AddDependency:
	groupId: org.mockito
	artifactId: mockito-junit-jupiter
	version: 3.x
	onlyIfUsing: org.mockito.junit.jupiter.MockitoExtension
	acceptTransitive: true

If you were to execute either of these recipes I think you should be upgraded to 4.x or 5.x

• org.openrewrite.java.testing.mockito.Mockito1to4Migration
• org.openrewrite.java.testing.mockito.Mockito1to5Migration

As per Mockito's 5.x release notes it seems that 5.x requires Java 11, whereas 4.x still works with Java 8. As our JUnit4to5Migration is intended to get you onto JUnit 5 without raising the required Java version just yet, I suppose we could only bump you up to Mockito 4.x, or make that conditional on the Java version in use.

In any case I believe we could fix all the above using only declarative Yaml recipes and preconditions. Would you want to help out making that a reality?

[MBoegers]

There is at least one more location in the recipeDependencies within

rewrite-testing-frameworks/build.gradle.kts

Line 23 in fd0eb2d

parserClasspath("org.mockito:mockito-junit-jupiter:3.+")

[Saturas89]

In any case I believe we could fix all the above using only declarative Yaml recipes and preconditions. Would you want to help out making that a reality?

unfortunately i am so busy with updating many projects, where i am very grateful for rewrite. i try to open up feedback & issues as best as possible. i have helped myself by pulling the version of mockito-junit-jupiter through a parent pom.

[timtebeek]

All good; as per the above I've for now changed our JUnit 5 upgrade to pull in Mockito 4.x via f1fda26
Thanks for pointing this out!