Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update typeguard to 3.x #327

Merged
merged 1 commit into from
Mar 17, 2023
Merged

Update typeguard to 3.x #327

merged 1 commit into from
Mar 17, 2023

Conversation

felixonmars
Copy link
Contributor

@felixonmars felixonmars commented Mar 16, 2023 •
edited
Loading

Description (e.g. "Related to ...", etc.)

Fixes incompatible function call and the expected test failure message.

Code review checklist (for code reviewer to complete)

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Commit messages are meaningful (see this for details)
  • Tests have been included and/or updated, as appropriate
  • Docstrings have been included and/or updated, as appropriate
  • Standalone docs have been updated accordingly
  • CONTRIBUTORS.md was updated, as appropriate
  • Changelog has been updated, as needed (see CHANGELOG.md)

@felixonmars
Update typeguard to 3.x
85c2527 
Fixes incompatible function call and the expected test failure message.
@tombh tombh requested review from tombh and alcarney March 16, 2023 23:00
@tombh
Copy link
Collaborator

tombh commented Mar 16, 2023

Thank you so much for this well-structured PR ❤️

It looks good, but I'm not familiar with check_type function. I wonder if @alcarney can give it the thumbs up too?

alcarney
alcarney approved these changes Mar 17, 2023
View reviewed changes
Copy link
Collaborator

@alcarney alcarney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🙂

@tombh tombh merged commit 9da56de into openlawlibrary:master Mar 17, 2023
@felixonmars felixonmars deleted the typeguard-3 branch March 17, 2023 16:45
@DelusionalOptimist DelusionalOptimist mentioned this pull request May 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tombh tombh tombh approved these changes

@alcarney alcarney alcarney approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@felixonmars @tombh @alcarney