Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: VisWaterNet: A Python package for visualization of water distribution networks #5138

Closed
editorialbot opened this issue Feb 9, 2023 · 28 comments
Assignees

Comments

@editorialbot
Copy link
Collaborator

editorialbot commented Feb 9, 2023

Submitting author: @meghnathomas (Meghna Thomas)
Repository: https://github.com/tylertrimble/viswaternet
Branch with paper.md (empty if default branch):
Version: v1.0.0
Editor: @crvernon
Reviewers: @erexer, @thurber
Managing EiC: Kristen Thyng

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/e9876602a7c3fdbfefe4ac8d913d3975"><img src="https://joss.theoj.org/papers/e9876602a7c3fdbfefe4ac8d913d3975/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/e9876602a7c3fdbfefe4ac8d913d3975/status.svg)](https://joss.theoj.org/papers/e9876602a7c3fdbfefe4ac8d913d3975)

Author instructions

Thanks for submitting your paper to JOSS @meghnathomas. Currently, there isn't a JOSS editor assigned to your paper.

@meghnathomas if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission (please start at the bottom of the list).

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
@editorialbot editorialbot added pre-review Track: 6 (ESE) Earth Sciences and Ecology labels Feb 9, 2023
@editorialbot
Copy link
Collaborator Author

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.88  T=0.08 s (687.6 files/s, 100413.9 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Python                          27            827           1757           3533
reStructuredText                17            265            249            324
Jupyter Notebook                 1              0            557            125
make                             2             25              6             76
YAML                             3             11             15             64
TeX                              1              6              0             61
Markdown                         2             21              0             55
DOS Batch                        1              8              1             27
INI                              1              4              0             15
-------------------------------------------------------------------------------
SUM:                            55           1167           2585           4280
-------------------------------------------------------------------------------


gitinspector failed to run statistical information for the repository

@editorialbot
Copy link
Collaborator Author

Wordcount for paper.md is 813

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1016/j.envsoft.2017.06.022 is OK
- 10.1101/gr.1239303 is OK
- 10.1007/978-3-642-18638-7_6 is OK
- 10.1109/MCSE.2007.55 is OK
- 10.1061/(ASCE)WR.1943-5452.0000191 is OK

MISSING DOIs

- None

INVALID DOIs

- None

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@meghnathomas
Copy link

Hi, this is a list of potential reviewers:

Mariosmsk
abhiramm7
amabdallah
glorialulu
kaklise
eladsal
rtaormina

@kthyng
Copy link

kthyng commented Feb 9, 2023

@meghnathomas Thank you for the list! I'm going to try to find an editor for you next.

@kthyng
Copy link

kthyng commented Feb 9, 2023

Hi @crvernon! Are you up for editing this?

@kthyng
Copy link

kthyng commented Feb 9, 2023

@editorialbot invite @crvernon as editor

@editorialbot
Copy link
Collaborator Author

There was a problem inviting the user to edit this submission.

@kthyng
Copy link

kthyng commented Feb 9, 2023

@editorialbot invite @crvernon as editor

@editorialbot
Copy link
Collaborator Author

Invitation to edit this submission sent!

@crvernon
Copy link

crvernon commented Feb 9, 2023

@editorialbot assign @crvernon as editor

@editorialbot
Copy link
Collaborator Author

Assigned! @crvernon is now the editor

@crvernon
Copy link

crvernon commented Feb 9, 2023

👋 @meghnathomas - I'll be your topic editor for this submission.

I'll get you two reviewers set up ASAP and then we can kick off the full review!

@crvernon
Copy link

crvernon commented Feb 9, 2023

👋 @erexer Would you be willing to review this submission to JOSS? We carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: https://joss.readthedocs.io/en/latest/review_criteria.html

@erexer
Copy link

erexer commented Feb 9, 2023

@crvernon happy to!

@crvernon
Copy link

crvernon commented Feb 9, 2023

@editorialbot assign @erexer as reviewer

@editorialbot
Copy link
Collaborator Author

I'm sorry human, I don't understand that. You can see what commands I support by typing:

@editorialbot commands

@crvernon
Copy link

crvernon commented Feb 9, 2023

@editorialbot add @erexer as reviewer

@editorialbot
Copy link
Collaborator Author

@erexer added to the reviewers list!

@crvernon
Copy link

crvernon commented Feb 9, 2023

👋 @thurber Would you be willing to review this submission to JOSS? We carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: https://joss.readthedocs.io/en/latest/review_criteria.html

@thurber
Copy link

thurber commented Feb 9, 2023

👋 @thurber Would you be willing to review this submission to JOSS? We carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: https://joss.readthedocs.io/en/latest/review_criteria.html

Yes, I am willing

@crvernon
Copy link

crvernon commented Feb 9, 2023

@editorialbot add @thurber as reviewer

@editorialbot
Copy link
Collaborator Author

@thurber added to the reviewers list!

@crvernon
Copy link

crvernon commented Feb 9, 2023

👋 - Alright @meghnathomas, @erexer , and @thurber I am going to close this Pre-Review and kick off the full review which you should receive a notification for. Thanks!

@crvernon
Copy link

crvernon commented Feb 9, 2023

@editorialbot start review

@editorialbot
Copy link
Collaborator Author

OK, I've started the review over in #5139.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants