Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: Agentpy: A package for agent-based modeling in Python #2966

Closed
whedon opened this issue Jan 16, 2021 · 28 comments
Closed

[PRE REVIEW]: Agentpy: A package for agent-based modeling in Python #2966

whedon opened this issue Jan 16, 2021 · 28 comments

Comments

@whedon
Copy link

whedon commented Jan 16, 2021

Submitting author: @JoelForamitti (Joël Foramitti)
Repository: https://github.com/JoelForamitti/agentpy
Version: v0.0.6
Editor: @sbenthall
Reviewers: @jamesdamillington, @martibosch
Managing EiC: Arfon Smith

⚠️ JOSS reduced service mode ⚠️

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

Author instructions

Thanks for submitting your paper to JOSS @JoelForamitti. Currently, there isn't an JOSS editor assigned to your paper.

The author's suggestion for the handling editor is @sbenthall.

@JoelForamitti if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission (please start at the bottom of the list).

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands
@whedon
Copy link
Author

whedon commented Jan 16, 2021

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks.

⚠️ JOSS reduced service mode ⚠️

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

For a list of things I can do to help you, just type:

@whedon commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@whedon generate pdf

@whedon
Copy link
Author

whedon commented Jan 16, 2021

Failed to discover a Statement of need section in paper

@whedon
Copy link
Author

whedon commented Jan 16, 2021

Software report (experimental):

github.com/AlDanial/cloc v 1.88  T=0.21 s (255.8 files/s, 314934.3 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Python                          26            780            897           2048
reStructuredText                15            159            113            380
Jupyter Notebook                 5              0          60268            331
Markdown                         2             24              0             84
TeX                              1              8              1             70
DOS Batch                        1              8              1             26
YAML                             2              0              0             25
make                             1              4              7              9
-------------------------------------------------------------------------------
SUM:                            53            983          61287           2973
-------------------------------------------------------------------------------


Statistical information for the repository 'fac91b9f95c172a839cb6807' was
gathered on 2021/01/16.
The following historical commit information, by author, was found:

Author                     Commits    Insertions      Deletions    % of changes
Joël Foramitti                  43          8545           4850          100.00

Below are the number of rows from each author that have survived and are still
intact in the current revision:

Author                     Rows      Stability          Age       % in comments
Joël Foramitti             3725           43.6          1.0                9.69

@whedon
Copy link
Author

whedon commented Jan 16, 2021

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1177/0963721419834547 is OK
- 10.3389/fevo.2018.00237 is OK

MISSING DOIs

- 10.1038/460685a may be a valid DOI for title: The economy needs agent-based modelling
- 10.1057/jos.2009.28 may be a valid DOI for title: Managing business complexity: discovering strategic solutions with agent-based modeling and simulation

INVALID DOIs

- https://doi.org/10.1002/wcc.647 is INVALID because of 'https://doi.org/' prefix
- https://doi.org/10.1002/wics.1356 is INVALID because of 'https://doi.org/' prefix
- https://doi.org/10.1016/j.cosrev.2017.03.001 is INVALID because of 'https://doi.org/' prefix

@whedon
Copy link
Author

whedon commented Jan 16, 2021

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@Kevin-Mattheus-Moerman
Copy link
Member

@sbenthall @KristinaRiemer could one of you edit this submission?

@Kevin-Mattheus-Moerman
Copy link
Member

@whedon invite @KristinaRiemer as editor

@whedon
Copy link
Author

whedon commented Jan 18, 2021

@KristinaRiemer has been invited to edit this submission.

@KristinaRiemer
Copy link

@Kevin-Mattheus-Moerman I'm not going to be able to edit this submission, sorry.

@kthyng
Copy link

kthyng commented Jan 22, 2021

@whedon invite @sbenthall as editor

@whedon
Copy link
Author

whedon commented Jan 22, 2021

@sbenthall has been invited to edit this submission.

@sbenthall
Copy link

Yes, I can edit this one :)

@danielskatz
Copy link

@sbenthall - you can @whedon assign me as editor whenever you are invited and agree, though I'll do it for you this time

@danielskatz
Copy link

@whedon assign @sbenthall as editor

@whedon
Copy link
Author

whedon commented Jan 25, 2021

OK, the editor is @sbenthall

@sbenthall
Copy link

@jamesdamillington would you be able to review this work?

@sbenthall
Copy link

@fdroessler would you be able to review this work?

@jamesdamillington
Copy link

@sbenthall yes, happy to review this

@sbenthall
Copy link

@whedon assign @jamesdamillington as reviewer

@whedon
Copy link
Author

whedon commented Feb 16, 2021

OK, @jamesdamillington is now a reviewer

@sbenthall
Copy link

@martibosch would you be able to review this work?

@martibosch
Copy link

Hello @sbenthall, sure, I'd be pleased to review this submission. Best,
Martí

@sbenthall
Copy link

Thank you!

@sbenthall
Copy link

@whedon add @martibosch as reviewer

@whedon
Copy link
Author

whedon commented Feb 26, 2021

OK, @martibosch is now a reviewer

@sbenthall
Copy link

Let's start this review!

@sbenthall
Copy link

@whedon start review

@whedon
Copy link
Author

whedon commented Feb 26, 2021

OK, I've started the review over in #3065.

@whedon whedon closed this as completed Feb 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants