Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: pypulseq #1678

Closed
whedon opened this issue Aug 23, 2019 · 36 comments
Closed

[PRE REVIEW]: pypulseq #1678

whedon opened this issue Aug 23, 2019 · 36 comments

Comments

@whedon
Copy link

whedon commented Aug 23, 2019

Submitting author: @imr-framework (Sairam Geethanath)
Repository: https://github.com/imr-framework/pypulseq
Version: 1.2.2
Editor: @Kevin-Mattheus-Moerman
Reviewers: @grlee77, @mathieuboudreau

Author instructions

Thanks for submitting your paper to JOSS @imr-framework. Currently, there isn't an JOSS editor assigned to your paper.

@imr-framework if you have any suggestions for potential reviewers then please mention them here in this thread. In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission.

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands
@whedon
Copy link
Author

whedon commented Aug 23, 2019

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@whedon commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@whedon generate pdf

What happens now?

This submission is currently in a pre-review state which means we are waiting for an editor to be assigned and for them to find some reviewers for your submission. This may take anything between a few hours to a couple of weeks. Thanks for your patience 😸

You can help the editor by looking at this list of potential reviewers to identify individuals who might be able to review your submission (please start at the bottom of the list). Also, feel free to suggest individuals who are not on this list by mentioning their GitHub handles here.

@whedon
Copy link
Author

whedon commented Aug 23, 2019

Attempting PDF compilation. Reticulating splines etc...

@kyleniemeyer
Copy link

Hi @Kevin-Mattheus-Moerman, another imaging-related submission—do you have the bandwidth to edit this one?

@whedon
Copy link
Author

whedon commented Aug 23, 2019

@Kevin-Mattheus-Moerman
Copy link
Member

@whedon assign @Kevin-Mattheus-Moerman as editor

@whedon
Copy link
Author

whedon commented Aug 24, 2019

OK, the editor is @Kevin-Mattheus-Moerman

@sravan953
Copy link

Hello @Kevin-Mattheus-Moerman , we'd like to suggest spinicist, grlee77, mwegrzyn as reviewers.

@grlee77
Copy link

grlee77 commented Aug 29, 2019

Hi @sravan953, I am interested in taking a look. I work in a Philips environment currently, but have also done sequence programming for GE and Siemens scanners in the past, so this is pretty relevant.

@Kevin-Mattheus-Moerman
Copy link
Member

@whedon assign @grlee77 as reviewer

@whedon
Copy link
Author

whedon commented Aug 29, 2019

OK, the reviewer is @grlee77

@Kevin-Mattheus-Moerman
Copy link
Member

@mwegrzyn are you interested in reviewing this work for JOSS?

@mwegrzyn
Copy link

Hello,
thank you for the invitation. This sounds very interesting, but I'm afraid I don't have the necessary physics knowledge to adequately understand the code. Sorry, but I'll have to pass.
Best regards, Martin Wegrzyn

@Kevin-Mattheus-Moerman
Copy link
Member

Kevin-Mattheus-Moerman commented Aug 30, 2019

@kelvinlayton @stefan-k would you be interested in reviewing this work for the Journal of Open Source Software (JOSS)? The review focuses largely on the software and a very short paper.

@stefan-k
Copy link

Thanks for the invitation!
I'm currently quite short on time, but I'll think about it and I'll let you know within the next couple of days. I should mention though that there may be a conflict of interest as I've collaborated with @imr-framework in the past and we've co-authored papers and conference contributions. I've also worked on a similar project which was abandoned in favor of the software which is up for review.

Maybe @m-a-x-i-m-z is interested in this too.

@sravan953
Copy link

@sairamgeethanath one reviewer still pending, am I right @Kevin-Mattheus-Moerman ?

@Kevin-Mattheus-Moerman
Copy link
Member

@sravan953 yes we are still recruiting reviewers. Aiming for 3 hopefully.

@Kevin-Mattheus-Moerman
Copy link
Member

@stefan-k thanks for your message and for clarifying the potential conflict of interest. Since we will have multiple reviewers without a conflict of interest, if you were to join decisions will not rest solely on your judgement/comments. Therefore, since it sounds like you could have valuable feedback, I'd still welcome your contribution as an additional reviewer. Let me know what you decide.

@stefan-k
Copy link

stefan-k commented Sep 3, 2019

Unfortunately I have to decline as I won't have time. Maybe @jfnielsen or @magland, who have worked on similar software, are interested to help out.

@jfnielsen
Copy link

I'm happy to review but like stefan-k I'm collaborating with the authors on related topics which is technically a conflict. I'm certainly interested though.

@Kevin-Mattheus-Moerman
Copy link
Member

@whedon add @jfnielsen as reviewer

@whedon
Copy link
Author

whedon commented Sep 4, 2019

OK, @jfnielsen is now a reviewer

@Kevin-Mattheus-Moerman
Copy link
Member

@jfnielsen thanks for pointing out the conflict of interest. I'll welcome you as an additional reviewer and will also recruit reviewers without a conflict of interest. Thanks for your help.

@Kevin-Mattheus-Moerman
Copy link
Member

@spinicist would you be interested in reviewing this work for the Journal of Open Source Software (JOSS)? The review focuses largely on the software and a very short paper.

@Kevin-Mattheus-Moerman
Copy link
Member

@whedon remove @jfnielsen as reviewer

@whedon
Copy link
Author

whedon commented Sep 4, 2019

OK, @jfnielsen is no longer a reviewer

@Kevin-Mattheus-Moerman
Copy link
Member

@jfnielsen After consulting with the editorial board it was decided to not include you due to the conflict of interest you referred to. My apologies for the confusion. Thanks again for offering to review for JOSS. I will consider you as a potential reviewer for other MRI related submissions.

@Kevin-Mattheus-Moerman
Copy link
Member

Kevin-Mattheus-Moerman commented Sep 5, 2019

@mfroeling @khammernik are you or your co-workers interested in reviewing this work for JOSS (The Journal of Open Source Software) on MRI pulse sequence design in Python? The review focuses largely on the software and a very short paper.

@Kevin-Mattheus-Moerman
Copy link
Member

@nstikov, @vsoch, @mathieuboudreau would you be interested in reviewing this JOSS submission?

@mathieuboudreau
Copy link

Sure!

@Kevin-Mattheus-Moerman
Copy link
Member

@whedon add @mathieuboudreau as reviewer

@whedon
Copy link
Author

whedon commented Sep 11, 2019

OK, @mathieuboudreau is now a reviewer

@Kevin-Mattheus-Moerman
Copy link
Member

@whedon start review

@whedon
Copy link
Author

whedon commented Sep 11, 2019

OK, I've started the review over in #1725. Feel free to close this issue now!

@Kevin-Mattheus-Moerman
Copy link
Member

This pre-review issue will now be closed. People interested in helping to review should head over to #1725.

@spinicist
Copy link

My apologies for missing the review request last week. If you need a 3rd reviewer for some reason let me know.

@Kevin-Mattheus-Moerman
Copy link
Member

@spinicist yes we do welcome a 3rd! I'll add you over at #1725. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

10 participants