Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenID4VP: Replace redirect_uri with response_uri for Response Mode direct_post #71

Closed
cryptphil opened this issue Nov 1, 2023 · 4 comments · Fixed by #73
Closed

OpenID4VP: Replace redirect_uri with response_uri for Response Mode direct_post #71

cryptphil opened this issue Nov 1, 2023 · 4 comments · Fixed by #73

Comments

@cryptphil
Copy link
Contributor

cryptphil commented Nov 1, 2023

The HAIP specifies in Section 5 for OpenID4VP that:

Response mode MUST be direct_post with redirect_uri as defined in Section 6.2 of OID4VP.

However, redirect_uri must not be present when the Response Mode is direct_post as described in the OpenID4VP specs in Section 6.2-7.2:

If the redirect_uri Authorization Request parameter is present when the Response Mode is direct_post, the Wallet MUST return an invalid_request Authorization Response error.

Therefore, I assume that the HAIP should use response_uri instead of redirect_uri which would align with the OpenID4VP specs.

@paulbastian
Copy link
Collaborator

I think you are correct.
To complicate things, the 200 Response to this may again include a redirect_uri see: https://openid.github.io/OpenID4VP/openid-4-verifiable-presentations-wg-draft.html#section-6.2-18.2

@c2bo
Copy link
Member

c2bo commented Nov 22, 2023

I think you are correct. To complicate things, the 200 Response to this may again include a redirect_uri see: https://openid.github.io/OpenID4VP/openid-4-verifiable-presentations-wg-draft.html#section-6.2-18.2

Stumbled over this today as well - is my understanding correct that this is necessary to prevent the session fixation attack described in 12.2. If so should we add this as a recommended/required step in this profile (mandating a redirect_uri as a response to the direct_post flow)?

@paulbastian
Copy link
Collaborator

If we mandate redirect, we mandate the same device flow, correct?
So I'm unsure

@Sakurann
Copy link
Contributor

OID4VP currently does not limit the usage of redirects after direct_post to only same-device flows. even though the security benefit that this redirect gives for the same-device does not apply for cross-device flows. before we make any clarifications on this topic in HAIP, we should probably make it clearer in oid4vp itself. here is the issue :)
openid/OpenID4VP#25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants