Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add video extension #100

Merged
merged 4 commits into from
Dec 9, 2020
Merged

add video extension #100

merged 4 commits into from
Dec 9, 2020

Conversation

lucienicolier
Copy link
Member

@@ -2,3 +2,4 @@ sphinx==1.8.5
Pygments>=2.0.1
sphinx_bootstrap_theme
transifex-client
pbr
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have much experience with sphinx but according to this https://github.com/opengisch/QField-docs/pull/100/checks?check_run_id=1509285590#step:7:289 it's not properly installed. I expected that there could be done a pip install sphinxcontrib.video but apparently it's not on pypi, so you could try pip install git+https://github.com/sphinx-contrib/video.git according to sphinx-contrib/video#2

@lucienicolier
Copy link
Member Author

@signedav I did add the pip extension, is that right?

@signedav
Copy link
Member

signedav commented Dec 7, 2020

I expected to have it in the requirements.txt but shouldn't make a difference.
It's running now through the workflow... But still not working?

Hm. Maybe @mbernasocchi has an idea.

@lucienicolier
Copy link
Member Author

@mbernasocchi I added an example with the search video.

@lucienicolier lucienicolier merged commit c95001e into master Dec 9, 2020
@lucienicolier lucienicolier deleted the video_ext branch December 9, 2020 15:41
@m-kuhn
Copy link
Member

m-kuhn commented Dec 10, 2020

There seems to be a problem with this pull request (see the chat on Ninjas)

  • The .webm file is not published (at least not to the expected location in _images).
  • This pull request removed two videos (search and go to coordinates) and replaced the go to coordinates video with the search video

@mbernasocchi can you have a look? Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants