Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow selection of source level control #66

Open
gareth-j opened this issue Sep 15, 2023 · 0 comments
Open

Allow selection of source level control #66

gareth-j opened this issue Sep 15, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@gareth-j
Copy link
Contributor

gareth-j commented Sep 15, 2023

It'd be good if the dashboard could be setup to customise itself based on the data read in. If we want users to just be able to select data by site then we just have markers and a popup detailing the site. If we want users to select by inlet then we create the buttons in the popup, if we want by instrument we have a couple of rows of buttons etc.

NOTE: I'll use source selection level here to mean selecting data by site or by inlet at a site etc

I've created a preliminary dashboard_config.json that can be read in by the dashboard that could control the setup of the markers / popups. See openghg/openghg#772 for the work on exporting this config file.

To implement this we'll need to

  • read in the dashboard_config.json file
  • update the createSourceKey function to create keys depending on the source selection level
  • pass through the setting to the LeafletMap component
  • modify the onClick so it's passed to inlet TextButton for inlet selection or the CircleMarker for site selection
  • add some tests to cover this dynamic change of UI
@gareth-j gareth-j added the enhancement New feature or request label Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant