-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Edge value can be incompatible with CRS #242
Comments
No ambiguity here. Planar on a geographic CRS means to consider the (longitude, latitude) space as a Cartesian coordinate space. This admitedly doesn't make sense to measure distances, but it is still widely used, like to define bounding boxes, despite its limitations |
While it may be common in some systems to treat spherical coordinates as planar, unless the specification states that that is how it is to be interpreted, it is ambiguous. Many reasonable possibilities exist. I know of one system that does not use that interpretation; instead, it uses the rhumb between the two points. That way bounding boxes still work; the path is defined; and the path is meaningful. I am not advocating any particular definition, but I advocate that it be defined. |
Thank you for bringing this up...I admit that I am surprised at the notion that the interpretation is ambiguous since the way that this is expressed in GeoParquet is quite flexible (for example, we defined the Is the ambiguity you are referring to that the |
I’m not sure what your first choice means, but yes, I disagree that the combination of edge = "planar" by default and crs = "OGC:CRS84" by default is a good thing. In a formal sense, it is ambiguous, since it does not define a path. @rouault gives the common usage, but if the common usage is what is intended, then it ought to be stated because its common use does not make it unique or ambiguous. In an informal sense, I think it’s poor practice to encourage flat-earth semantics, with the usual attendant errors, by mashing up a spheroidal CRS with a planar edge by default. |
Unfortunately I don't think we can change the defaults or how they are specified as we have a number of existing implementations; however, we could definitely do a better job disambiguating the meaning of
I agree! I have found that a productive outlet for myself is to help develop open source alternatives that make it easy to do the right thing (e.g., https://github.com/paleolimbot/s2geography/ , https://github.com/r-spatial/s2 ). Until we have a widely available and rigorously tested drop-in alternative for GEOS/JTS, I don't see a spherical default as a viable option. |
The spec permits the edge value to either planar or spherical, without restriction, and defaults to planar. Meanwhile the default CRS is spheroidal, setting up a meaningless edge definition by default, as well as permitting a planar edge value to be explicitly assigned even when the CRS is spheroidal. Either the spec should prohibit the incompatible declarations or should specify an unambiguous mathematical meaning for a planar edge on a spheroidal datum.
The text was updated successfully, but these errors were encountered: