From c94bcafae19ba35e80301815bedd6f50531a6dde Mon Sep 17 00:00:00 2001 From: Dewey Dunnington Date: Tue, 30 Jan 2024 11:49:30 -0400 Subject: [PATCH] Apply suggestions from code review Co-authored-by: Joris Van den Bossche Co-authored-by: Kyle Barron --- examples/example_metadata-geoarrow.json | 2 +- format-specs/compatible-parquet.md | 2 +- format-specs/geoparquet.md | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/examples/example_metadata-geoarrow.json b/examples/example_metadata-geoarrow.json index 047980e..b95c1bd 100644 --- a/examples/example_metadata-geoarrow.json +++ b/examples/example_metadata-geoarrow.json @@ -3,7 +3,7 @@ "columns": { "geometry": { "encoding": "geoarrow", - "extension_name": "geoarrow.point", + "geoarrow_type": "geoarrow.point", "geometry_types": [ "Point" ] diff --git a/format-specs/compatible-parquet.md b/format-specs/compatible-parquet.md index d7de290..5f40633 100644 --- a/format-specs/compatible-parquet.md +++ b/format-specs/compatible-parquet.md @@ -12,7 +12,7 @@ The core idea of the compatibility guidelines is to have the output match the de * The geometry column should be named either `"geometry"` or `"geography"`. -* The geometry column should be a `BYTE_ARRAY` with Well Known Binary (WKB) used to define the geometries, as defined in the [encoding](./geoparquet.md#encoding) section of the GeoParquet spec. Alternatively, the geometry column can be stored according to the Point, MultiPoint, MultiLinestring, or MultiPolygon memory layouts with separated (struct) coordinates as specified in the [GeoArrow format](https://geoarrow.org/format). +* The geometry column should be a `BYTE_ARRAY` with Well Known Binary (WKB) used to define the geometries, as defined in the [encoding](./geoparquet.md#encoding) section of the GeoParquet spec. Alternatively, the geometry column can be stored according to the Point, MultiPoint, MultiLineString, or MultiPolygon memory layouts with separated (struct) coordinates as specified in the [GeoArrow format](https://geoarrow.org/format). * All data is stored in longitude, latitude based on the WGS84 datum, as defined as the default in the [crs](./geoparquet.md#crs) section of the GeoParquet spec. diff --git a/format-specs/geoparquet.md b/format-specs/geoparquet.md index 8546f34..a852161 100644 --- a/format-specs/geoparquet.md +++ b/format-specs/geoparquet.md @@ -54,7 +54,7 @@ Each geometry column in the dataset MUST be included in the `columns` field abov | edges | string | Name of the coordinate system for the edges. Must be one of `"planar"` or `"spherical"`. The default value is `"planar"`. | | bbox | \[number] | Bounding Box of the geometries in the file, formatted according to [RFC 7946, section 5](https://tools.ietf.org/html/rfc7946#section-5). | | epoch | number | Coordinate epoch in case of a dynamic CRS, expressed as a decimal year. | -| geoarrow_type | string | The [GeoArrow extension name](https://geoarrow.org/extension-types#extension-names) corresponding to the column memory layout. This is required when `encoding` is `"geoarrow"` and must be omitted otherwise. | +| geoarrow_type | string | The [GeoArrow extension name](https://geoarrow.org/extension-types#extension-names) corresponding to the column memory layout. This is required when `encoding` is `"geoarrow"` and must be omitted otherwise. | #### crs